2009-09-29 13:47:08

by Claudio Takahasi

Subject: [PATCH] obex-client API - Missing method

Hi Marcel/Johan,

"Close" method description on Session interface is missing, I added a
brief description on my branch "devel":

git://git.infradead.org/users/cktakahasi/obexd.git devel

BTW, CopyFile and MoveFile are not implemented yet, we need to remove
the code or write in the API that it is not implemented yet.

Br,
Claudio.
--
--
Claudio Takahasi
Instituto Nokia de Tecnologia
Recife - Pernambuco - Brasil
+55 81 30879999

2009-09-29 15:02:19

by Claudio Takahasi

Subject: Re: [PATCH] obex-client API - Missing method

On Tue, Sep 29, 2009 at 11:10 AM, Johan Hedberg <[email protected]> wrote:
> Hi Claudio,
>
> On Tue, Sep 29, 2009, Claudio Takahasi wrote:
>> "Close" method  description on Session interface is missing, I added a
>> brief description on my branch "devel":
>>
>> git://git.infradead.org/users/cktakahasi/obexd.git devel
>
> The patch has been pushed upstream (with a minor language fix). Thanks.
>
> Johan
>

Hi Johan/Marcel,

I noticed that "Close" on Session interface looks like a "self kill".
The current behavior is: unregister transfer
interface (if exists) and after unregister session interface(if ref
reaches zero). Maybe a better place(if we rename it to RemoveSession)
is "org.openobex.Client" interface, the same interface of CreateSession.

Krau.

2009-09-29 14:10:27

by Johan Hedberg

Subject: Re: [PATCH] obex-client API - Missing method

Hi Claudio,

On Tue, Sep 29, 2009, Claudio Takahasi wrote:
> "Close" method description on Session interface is missing, I added a
> brief description on my branch "devel":
>
> git://git.infradead.org/users/cktakahasi/obexd.git devel

The patch has been pushed upstream (with a minor language fix). Thanks.

Johan