2014-12-22 13:16:51

by Andrei Emeltchenko

Subject: [PATCH] shared/hfp: Remove dead code

From: Andrei Emeltchenko <[email protected]>

Remove dead code since free_tmp initialized to false.
---
src/shared/hfp.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/src/shared/hfp.c b/src/shared/hfp.c
index 9d937a5..05a8563 100644
--- a/src/shared/hfp.c
+++ b/src/shared/hfp.c
@@ -1192,10 +1192,6 @@ static void hf_process_input(struct hfp_hf *hfp)
if (len == ringbuf_len(hfp->read_buf))
goto done;

- /* If we are here second time for some reason, that is wrong */
- if (free_tmp)
- goto done;
-
str2 = ringbuf_peek(hfp->read_buf, len, &len2);
if (!str2)
goto done;
--
2.1.0

2015-01-07 09:51:32

by Johan Hedberg

Subject: Re: [PATCH] shared/hfp: Remove dead code

Hi Andrei,

On Mon, Dec 22, 2014, Andrei Emeltchenko wrote:
> Remove dead code since free_tmp initialized to false.
> ---
> src/shared/hfp.c | 4 ----
> 1 file changed, 4 deletions(-)

Applied. Thanks.

Johan

2015-01-07 09:17:19

by Andrei Emeltchenko

Subject: Re: [PATCH] shared/hfp: Remove dead code

ping

On Mon, Dec 22, 2014 at 03:16:51PM +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Remove dead code since free_tmp initialized to false.
> ---
> src/shared/hfp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/src/shared/hfp.c b/src/shared/hfp.c
> index 9d937a5..05a8563 100644
> --- a/src/shared/hfp.c
> +++ b/src/shared/hfp.c
> @@ -1192,10 +1192,6 @@ static void hf_process_input(struct hfp_hf *hfp)
> if (len == ringbuf_len(hfp->read_buf))
> goto done;
>
> - /* If we are here second time for some reason, that is wrong */
> - if (free_tmp)
> - goto done;
> -
> str2 = ringbuf_peek(hfp->read_buf, len, &len2);
> if (!str2)
> goto done;
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html