2019-01-11 20:57:14

by Stefan Agner

Subject: [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages

Use dev_* variants to print messages in drivers.

Signed-off-by: Stefan Agner <[email protected]>
---
drivers/bluetooth/btmrvl_sdio.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index fb3d03928460..6f9a1735039d 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -62,13 +62,14 @@ static const struct of_device_id btmrvl_sdio_of_match_table[] = {
static irqreturn_t btmrvl_wake_irq_bt(int irq, void *priv)
{
struct btmrvl_sdio_card *card = priv;
+ struct device *dev = &card->func->dev;
struct btmrvl_plt_wake_cfg *cfg = card->plt_wake_cfg;

- pr_info("%s: wake by bt\n", __func__);
+ dev_info(dev, "wake by bt\n");
cfg->wake_by_bt = true;
disable_irq_nosync(irq);

- pm_wakeup_event(&card->func->dev, 0);
+ pm_wakeup_event(dev, 0);
pm_system_wakeup();

return IRQ_HANDLED;
@@ -87,7 +88,7 @@ static int btmrvl_sdio_probe_of(struct device *dev,

if (!dev->of_node ||
!of_match_node(btmrvl_sdio_of_match_table, dev->of_node)) {
- pr_err("sdio platform data not available\n");
+ dev_err(dev, "sdio platform data not available\n");
return -1;
}

--
2.20.1

2019-01-11 20:57:17

by Stefan Agner

Subject: [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message

The platform specific wake-up interrupt is optional. Don't print
an error message in case it is missing, merely inform the user in
this case.

Signed-off-by: Stefan Agner <[email protected]>
---
drivers/bluetooth/btmrvl_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 6f9a1735039d..8ff4c31e0e48 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -88,7 +88,7 @@ static int btmrvl_sdio_probe_of(struct device *dev,

if (!dev->of_node ||
!of_match_node(btmrvl_sdio_of_match_table, dev->of_node)) {
- dev_err(dev, "sdio platform data not available\n");
+ dev_info(dev, "sdio device tree data not available\n");
return -1;
}

--
2.20.1

2019-01-18 09:14:47

by Marcel Holtmann

Subject: Re: [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages

Hi Stefan,

> Use dev_* variants to print messages in drivers.
>
> Signed-off-by: Stefan Agner <[email protected]>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

2019-01-18 09:15:08

by Marcel Holtmann

Subject: Re: [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message

Hi Stefan,

> The platform specific wake-up interrupt is optional. Don't print
> an error message in case it is missing, merely inform the user in
> this case.
>
> Signed-off-by: Stefan Agner <[email protected]>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel