2020-04-24 23:11:49

by Tedd Ho-Jeong An

Subject: [PATCH 3/3] Test patch #3: OPEN_BRACE

DO NOT MERGE

Test patch #3
---
tools/btpclient.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/btpclient.c b/tools/btpclient.c
index 7248acc2a..e2eff9575 100644
--- a/tools/btpclient.c
+++ b/tools/btpclient.c
@@ -228,7 +228,8 @@ static struct btp_device *find_device_by_path(const char *path)
struct btp_device *device;

for (entry = l_queue_get_entries(adapters); entry;
- entry = entry->next) {
+ entry = entry->next)
+ {
struct btp_adapter *adapter = entry->data;

device = l_queue_find(adapter->devices, match_device_paths,
--
2.25.3

2020-04-25 02:36:05

by bluez.test.bot

Subject: RE: [3/3] Test patch #3: OPEN_BRACE

This is automated email and please do not replay to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.


Test Result:
Checkpatch Failed

Patch Title:
[3/3] Test patch #3: OPEN_BRACE

Output:
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#17: FILE: tools/btpclient.c:230:
for (entry = l_queue_get_entries(adapters); entry;
+ entry = entry->next)
+ {

- total: 1 errors, 0 warnings, 9 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.



For more details about BlueZ coding style guide, please find it
in doc/coding-style.txt

---
Regards,
Linux Bluetooth