2021-04-16 21:57:45

by Tedd Ho-Jeong An

Subject: [BlueZ PATCH] monitor: Add Intel read supported VS features command

From: Tedd Ho-Jeong An <[email protected]>

< HCI Command: Intel Read Supported VS Features (0x3f|0x00a6) plen 1
Page: 0x01
> HCI Event: Command Complete (0x0e) plen 22
Intel Read Supported VS Features (0x3f|0x00a6) ncmd 1
Status: Success (0x00)
Page: 0x01
Max Pages: 0x02
Supported Features:
1f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
---
monitor/intel.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/monitor/intel.c b/monitor/intel.c
index 18840f3e7..1aee29cc8 100644
--- a/monitor/intel.c
+++ b/monitor/intel.c
@@ -471,6 +471,25 @@ static void memory_write_cmd(const void *data, uint8_t size)
packet_hexdump(data + 6, size - 6);
}

+static void read_supported_vs_features_cmd(const void *data, uint8_t size)
+{
+ uint8_t page = get_u8(data);
+ print_field("Page: 0x%2.2x", page);
+}
+
+static void read_supported_vs_features_rsp(const void *data, uint8_t size)
+{
+ uint8_t status = get_u8(data);
+ uint8_t page = get_u8(data + 1);
+ uint8_t max_pages = get_u8(data + 2);
+
+ print_status(status);
+ print_field("Page: 0x%2.2x", page);
+ print_field("Max Pages: 0x%2.2x", max_pages);
+ print_field("Supported Features:");
+ packet_hexdump(data + 3, size - 3);
+}
+
static const struct vendor_ocf vendor_ocf_table[] = {
{ 0x001, "Reset",
reset_cmd, 8, true,
@@ -533,6 +552,10 @@ static const struct vendor_ocf vendor_ocf_table[] = {
{ 0x08e, "Memory Write",
memory_write_cmd, 6, false,
status_rsp, 1, true },
+ { 0x0a6, "Read Supported VS Features",
+ read_supported_vs_features_cmd, 1, true,
+ read_supported_vs_features_rsp, 19, true },
+
{ }
};

--
2.25.1

2021-04-16 22:03:58

by bluez.test.bot

Subject: RE: [BlueZ] monitor: Add Intel read supported VS features command

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=468819

---Test result---

Test Summary:
CheckPatch FAIL 0.38 seconds
GitLint PASS 0.13 seconds
Prep - Setup ELL PASS 48.88 seconds
Build - Prep PASS 0.15 seconds
Build - Configure PASS 8.45 seconds
Build - Make PASS 205.84 seconds
Make Check PASS 9.07 seconds
Make Dist PASS 11.93 seconds
Make Dist - Configure PASS 5.23 seconds
Make Dist - Make PASS 83.00 seconds
Build w/ext ELL - Configure PASS 8.24 seconds
Build w/ext ELL - Make PASS 194.16 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
monitor: Add Intel read supported VS features command
WARNING:LINE_SPACING: Missing a blank line after declarations
#27: FILE: monitor/intel.c:477:
+ uint8_t page = get_u8(data);
+ print_field("Page: 0x%2.2x", page);

- total: 0 errors, 1 warnings, 35 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] monitor: Add Intel read supported VS features command" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball

##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball

##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth