2021-05-26 22:51:05

by Tedd Ho-Jeong An

Subject: [PATCH V2] Bluetooth: mgmt: Fix the command returns garbage parameter value

From: Tedd Ho-Jeong An <[email protected]>

When the Get Device Flags command fails, it returns the error status
with the parameters filled with the garbage values. Although the
parameters are not used, it is better to fill with zero than the random
values.

Signed-off-by: Tedd Ho-Jeong An <[email protected]>
---
net/bluetooth/mgmt.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b44e19c69c44..91d36c3bf23e 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -4061,6 +4061,8 @@ static int get_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,

hci_dev_lock(hdev);

+ memset(&rp, 0, sizeof(rp));
+
if (cp->addr.type == BDADDR_BREDR) {
br_params = hci_bdaddr_list_lookup_with_flags(&hdev->whitelist,
&cp->addr.bdaddr,
--
2.26.3

2021-05-27 21:46:32

by Marcel Holtmann

Subject: Re: [PATCH V2] Bluetooth: mgmt: Fix the command returns garbage parameter value

Hi Tedd,

> When the Get Device Flags command fails, it returns the error status
> with the parameters filled with the garbage values. Although the
> parameters are not used, it is better to fill with zero than the random
> values.
>
> Signed-off-by: Tedd Ho-Jeong An <[email protected]>
> ---
> net/bluetooth/mgmt.c | 2 ++
> 1 file changed, 2 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel