From: Stefan Eichenberger <[email protected]>
The 88W8997 bluetooth module supports setting the max-speed property.
Signed-off-by: Stefan Eichenberger <[email protected]>
Signed-off-by: Francesco Dolcini <[email protected]>
---
.../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
index 83b64ed730f5..2fccea30c58d 100644
--- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
@@ -19,9 +19,25 @@ properties:
- mrvl,88w8897
- mrvl,88w8997
+ max-speed:
+ description: see Documentation/devicetree/bindings/serial/serial.yaml
+
required:
- compatible
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mrvl,88w8997
+ then:
+ properties:
+ max-speed: true
+ else:
+ properties:
+ max-speed: false
+
additionalProperties: false
examples:
--
2.25.1
On 18/01/2023 13:28, Francesco Dolcini wrote:
> From: Stefan Eichenberger <[email protected]>
>
> The 88W8997 bluetooth module supports setting the max-speed property.
>
> Signed-off-by: Stefan Eichenberger <[email protected]>
> Signed-off-by: Francesco Dolcini <[email protected]>
> ---
> .../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
> index 83b64ed730f5..2fccea30c58d 100644
> --- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
> @@ -19,9 +19,25 @@ properties:
> - mrvl,88w8897
> - mrvl,88w8997
>
> + max-speed:
> + description: see Documentation/devicetree/bindings/serial/serial.yaml
> +
> required:
> - compatible
>
> +allOf:
> + - if:
> + properties:
Wrong indentation, missing two spaces.
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
On Wed, 18 Jan 2023 13:28:15 +0100, Francesco Dolcini wrote:
> From: Stefan Eichenberger <[email protected]>
>
> The 88W8997 bluetooth module supports setting the max-speed property.
>
> Signed-off-by: Stefan Eichenberger <[email protected]>
> Signed-off-by: Francesco Dolcini <[email protected]>
> ---
> .../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/marvell-bluetooth.yaml:29:8: [error] empty value in block mapping (empty-values)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml: allOf:0:if: None is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml: ignoring, error in schema: allOf: 0: if
Documentation/devicetree/bindings/net/marvell-bluetooth.example.dtb: /example-0/serial/bluetooth: failed to match any schema with compatible: ['mrvl,88w8897']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.