2008-11-21 02:24:00

by Nick Pelly

[permalink] [raw]
Subject: patch: Respect HCI_UART_DEBUG config in hci_ll.c

Author: Nick Pelly <[email protected]>
Date: Mon Apr 21 12:18:51 2008 -0700

bluetooth: Respect HCI_UART_DEBUG config in hci_ll.c

Following the pattern from hci_*.c, turn off BT_DBG messages unless
they have been requested via HCI_UART_DEBUG

Signed-off-by: Brian Swetland <[email protected]>

diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index b91d45a..2d2f66e 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -51,6 +51,11 @@

#include "hci_uart.h"

+#ifndef CONFIG_BT_HCIUART_DEBUG
+#undef BT_DBG
+#define BT_DBG( A... )
+#endif
+
/* HCILL commands */
#define HCILL_GO_TO_SLEEP_IND 0x30
#define HCILL_GO_TO_SLEEP_ACK 0x31


Attachments:
fix_hcill_debug.txt (759.00 B)

2008-11-30 09:04:01

by Marcel Holtmann

[permalink] [raw]
Subject: Re: patch: Respect HCI_UART_DEBUG config in hci_ll.c

Hi Nick,

> Author: Nick Pelly <[email protected]>
> Date: Mon Apr 21 12:18:51 2008 -0700
>
> bluetooth: Respect HCI_UART_DEBUG config in hci_ll.c
>
> Following the pattern from hci_*.c, turn off BT_DBG messages unless
> they have been requested via HCI_UART_DEBUG
>
> Signed-off-by: Brian Swetland <[email protected]>

you have to fix your mail client to _NOT_ send mutli-part crap. Please
follow the proper guidelines for sending kernel patches. Otherwise you
make it complicated for me to apply patches. Especially these no
brainers.

So who wrote this patch? You are Brian. If you wrote the patch like
author indicated, then Brian should do an Acked-by unless he actually
sends the patch to me. In this case you send the patch so it should look
like this:

Signed-off-by: Nick Pelly <[email protected]>
Acked-by: Brian Swetland <[email protected]>

If you wrote the patch and Brian sent it to me, then he has to do
Signed-off since he is part of the chain. It is all documented in the
kernel source code :)

Regards

Marcel