2009-03-27 21:13:57

by Nick Pelly

[permalink] [raw]
Subject: Re: [PATCH] AVDTP Qualification: Use GENERAL_REJECT instead of REJECT for unknown command.

On Fri, Mar 27, 2009 at 1:49 PM, Johan Hedberg <[email protected]> wrote:
> On Fri, Mar 27, 2009, Johan Hedberg wrote:
>> > From: Nick Pelly <[email protected]>
>> > Date: Fri, 27 Mar 2009 12:57:45 -0700
>> > Subject: [PATCH 1/2] AVCTP qualification: Handle more error codes.
>>
>> This one has been pushed upstream. Thanks.
>
> Sorry, that was supposed to refer to the other patch. The general reject one
> doesn't look right. There's no message type of 0x01 according to AVDTP 1.2. The
> way I interpret it is that general reject should use the normal reject message
> type.

Here is the information we received from a partner for this patch:

TP-SIG-SMG-BI-28-C

Test Condition
Fields of AVDTP_CMD:
- Transaction_label = TransactionLowerTester = Any value
- Packet_type = 00 (single packet)
- Reserved = 00
- Message_type = 00 (command)
- Signal_Id = 0x3F (Undefined signal id)

Pass verdict
The lower tester receives the AVDTP signaling message with the fields:
Transaction_label = TransactionLowerTester
Packet_type = 00 (single packet)
Message type = 01 (general reject)
Bits 6 and 7 of Octet 1 are both set to ?0?
Other 6 bits = Set to the invalid signal identifier being rejected (0x3F)


However I can't find this same information in the current version of
the AVDTP test specification. Maybe it was from an older version of
the test spec? I couldn't work out where on bluetooth.org to get older
versions of test specs so I cannot confirm this.

In any case, we were told this change is recommended by the BQE, but
not required. So probably fine to skip this one.

Nick

2009-03-27 20:49:54

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] AVDTP Qualification: Use GENERAL_REJECT instead of REJECT for unknown command.

On Fri, Mar 27, 2009, Johan Hedberg wrote:
> > From: Nick Pelly <[email protected]>
> > Date: Fri, 27 Mar 2009 12:57:45 -0700
> > Subject: [PATCH 1/2] AVCTP qualification: Handle more error codes.
>
> This one has been pushed upstream. Thanks.

Sorry, that was supposed to refer to the other patch. The general reject one
doesn't look right. There's no message type of 0x01 according to AVDTP 1.2. The
way I interpret it is that general reject should use the normal reject message
type.

Johan

2009-03-27 20:48:20

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] AVDTP Qualification: Use GENERAL_REJECT instead of REJECT for unknown command.

Hi Nick,

On Fri, Mar 27, 2009, Nick Pelly wrote:
> From: Nick Pelly <[email protected]>
> Date: Fri, 27 Mar 2009 12:57:45 -0700
> Subject: [PATCH 1/2] AVCTP qualification: Handle more error codes.

This one has been pushed upstream. Thanks.

Johan