LinuxLists.cc - rfcomm exit code patch

2009-01-05 19:48:55

Subject: rfcomm exit code patch

Hi,

rfcomm does not always indicate failure in it's exit codes, which is a
problem when automating things.

Please consider this patch.

Thanks,
Jesse

Attachments:

rfcomm.patch (6.21 kB)

2009-01-06 14:52:39

by Jesse Long

[permalink] [raw]

Subject: Re: rfcomm exit code patch

Marcel Holtmann wrote:
> Hi Jesse,
>
>
>> rfcomm does not always indicate failure in it's exit codes, which is a
>> problem when automating things.
>>
>> Please consider this patch.
>>
>
> your patch is full of whitespaces/tabs coding style violations. Please
> fix them first.
>
> Also error return values should be negative.
>
> Regards
>
> Marcel
>
Hi Marcel,

Thanks for the reply. Apologies. Here is a new patch.

Regards,
Jesse

Attachments:

bluez-rfcomm-exitcode.patch (6.13 kB)

2009-01-06 02:38:29

by Marcel Holtmann

[permalink] [raw]

Subject: Re: rfcomm exit code patch

Hi Jesse,

> rfcomm does not always indicate failure in it's exit codes, which is a
> problem when automating things.
>
> Please consider this patch.

your patch is full of whitespaces/tabs coding style violations. Please
fix them first.

Also error return values should be negative.

Regards

Marcel