2009-09-10 03:16:44

by Timothy Madden

Subject: Source device selection for org.bluez.client.SendFiles

I noticed method SendFiles in org.bluez.client was ignoring the given
source in the device dictionary passed as argument.

I had to modify the send_files() function in obexd-0.17/client/main.c
and replace the NULL parameter it was passing on to session_create
with the given source from the dictionary. Than I could select the
source device when calling SendFiles from python. Should I send in a
patch ?


Thank you,
Timothy Madden

2009-09-10 15:24:54

by Timothy Madden

Subject: Re: Source device selection for org.bluez.client.SendFiles

Oh, yes, indeed

On Thu, Sep 10, 2009 at 9:32 AM, Marcel Holtmann <[email protected]> wrote:
> Hi Timothy,
>
>> I noticed method SendFiles in org.bluez.client was ignoring the given
>> source in the device dictionary passed as argument.
>>
>> I had to modify the send_files() function in obexd-0.17/client/main.c
>> and replace the NULL parameter it was passing on to session_create
>> with the given source from the dictionary. Than I could select the
>> source device when calling SendFiles from python. Should I send in a
>> patch ?
>
> you mean something like this:
>
> commit e1214330b4391d5577e5e2411a6ee34604d6bea4
> Author: Claudio Takahasi <[email protected]>
> Date: ? Thu Sep 3 11:17:42 2009 -0300
>
> ? ?Fixed SendFiles to use "Source" argument.
>
> ? ?SendFiles was ignoring "Source" argument and using the default adapter
> ? ?always.
>
> diff --git a/client/main.c b/client/main.c
> index e903a75..32eca26 100644
> --- a/client/main.c
> +++ b/client/main.c
> @@ -187,7 +187,7 @@ static DBusMessage *send_files(DBusConnection *connection,
> ? ? ? ?data->agent = g_strdup(agent);
> ? ? ? ?data->files = files;
>
> - ? ? ? if (session_create(NULL, dest, "OPP", channel, create_callback,
> + ? ? ? if (session_create(source, dest, "OPP", channel, create_callback,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?data) == 0)
> ? ? ? ? ? ? ? ?return NULL;
>
> Regards
>
> Marcel
>
>
>

2009-09-10 06:32:49

by Marcel Holtmann

Subject: Re: Source device selection for org.bluez.client.SendFiles

Hi Timothy,

> I noticed method SendFiles in org.bluez.client was ignoring the given
> source in the device dictionary passed as argument.
>
> I had to modify the send_files() function in obexd-0.17/client/main.c
> and replace the NULL parameter it was passing on to session_create
> with the given source from the dictionary. Than I could select the
> source device when calling SendFiles from python. Should I send in a
> patch ?

you mean something like this:

commit e1214330b4391d5577e5e2411a6ee34604d6bea4
Author: Claudio Takahasi <[email protected]>
Date: Thu Sep 3 11:17:42 2009 -0300

Fixed SendFiles to use "Source" argument.

SendFiles was ignoring "Source" argument and using the default adapter
always.

diff --git a/client/main.c b/client/main.c
index e903a75..32eca26 100644
--- a/client/main.c
+++ b/client/main.c
@@ -187,7 +187,7 @@ static DBusMessage *send_files(DBusConnection *connection,
data->agent = g_strdup(agent);
data->files = files;

- if (session_create(NULL, dest, "OPP", channel, create_callback,
+ if (session_create(source, dest, "OPP", channel, create_callback,
data) == 0)
return NULL;

Regards

Marcel