2021-02-22 06:10:32

by Archie Pusaka

[permalink] [raw]
Subject: [Bluez PATCH] adapter: fix set_mode MGMT_OP_SET_BONDABLE

From: Archie Pusaka <[email protected]>

Currently pending_settings is assigned MGMT_SETTING_DISCOVERABLE,
but it should have been MGMT_SETTING_BONDABLE instead.
---

src/adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/adapter.c b/src/adapter.c
index c1f976323e..ae1a70b5ba 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -646,7 +646,7 @@ static bool set_mode(struct btd_adapter *adapter, uint16_t opcode,
setting = MGMT_SETTING_DISCOVERABLE;
break;
case MGMT_OP_SET_BONDABLE:
- setting = MGMT_SETTING_DISCOVERABLE;
+ setting = MGMT_SETTING_BONDABLE;
break;
}

--
2.30.0.617.g56c4b15f3c-goog


2021-02-22 06:41:57

by bluez.test.bot

[permalink] [raw]
Subject: RE: [Bluez] adapter: fix set_mode MGMT_OP_SET_BONDABLE

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=436335

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth

2021-02-22 18:29:26

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [Bluez] adapter: fix set_mode MGMT_OP_SET_BONDABLE

Hi Archie,

On Sun, Feb 21, 2021 at 10:41 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=436335
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth
>

Applied, thanks.

--
Luiz Augusto von Dentz