2021-03-16 20:28:02

by Frédéric Danis

[permalink] [raw]
Subject: [PATCH Bluez] android/handsfree: Replace g_timeout_add_seconds_full by g_timeout_add_seconds

The call uses the default priority value and doe not set a destroy
function, in this case g_timeout_add_seconds can be used.
---
android/handsfree.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/android/handsfree.c b/android/handsfree.c
index 2365356c2..977803111 100644
--- a/android/handsfree.c
+++ b/android/handsfree.c
@@ -2330,9 +2330,7 @@ static void phone_state_incoming(struct hf_device *dev, int num_active,
/* send first RING */
ring_cb(dev);

- dev->ring = g_timeout_add_seconds_full(G_PRIORITY_DEFAULT,
- RING_TIMEOUT, ring_cb,
- dev, NULL);
+ dev->ring = g_timeout_add_seconds(RING_TIMEOUT, ring_cb, dev);
if (!dev->ring) {
g_free(dev->clip);
dev->clip = NULL;
--
2.18.0


2021-03-16 22:33:59

by bluez.test.bot

[permalink] [raw]
Subject: RE: [Bluez] android/handsfree: Replace g_timeout_add_seconds_full by g_timeout_add_seconds

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=449061

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - FAIL
Output:
android/handsfree: Replace g_timeout_add_seconds_full by g_timeout_add_seconds
1: T1 Title exceeds max length (78>72): "android/handsfree: Replace g_timeout_add_seconds_full by g_timeout_add_seconds"


##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth