2021-06-17 01:59:26

by Nigel Christian

[permalink] [raw]
Subject: [PATCH] Bluetooth: hci_uart: Remove redundant assignment to fw_ptr

The variable fw_ptr is assigned a value that is not read and the same value
is assigned in the patch goto. The assignment is redundant and can be
removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Nigel Christian <[email protected]>
---
drivers/bluetooth/hci_ag6xx.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/bluetooth/hci_ag6xx.c b/drivers/bluetooth/hci_ag6xx.c
index 1f55df93e4ce..2d40302409ff 100644
--- a/drivers/bluetooth/hci_ag6xx.c
+++ b/drivers/bluetooth/hci_ag6xx.c
@@ -199,7 +199,6 @@ static int ag6xx_setup(struct hci_uart *hu)
fwname, err);
goto patch;
}
- fw_ptr = fw->data;

bt_dev_info(hdev, "Applying bddata (%s)", fwname);

--
2.31.1


2021-06-17 02:26:36

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: hci_uart: Remove redundant assignment to fw_ptr

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=501833

---Test result---

Test Summary:
CheckPatch PASS 0.74 seconds
GitLint PASS 0.14 seconds
BuildKernel PASS 688.25 seconds
TestRunner: Setup PASS 443.25 seconds
TestRunner: l2cap-tester PASS 3.19 seconds
TestRunner: bnep-tester PASS 2.17 seconds
TestRunner: mgmt-tester PASS 32.34 seconds
TestRunner: rfcomm-tester PASS 2.47 seconds
TestRunner: sco-tester PASS 2.40 seconds
TestRunner: smp-tester PASS 2.40 seconds
TestRunner: userchan-tester PASS 2.29 seconds

Details
##############################
Test: CheckPatch - PASS - 0.74 seconds
Run checkpatch.pl script with rule in .checkpatch.conf


##############################
Test: GitLint - PASS - 0.14 seconds
Run gitlint with rule in .gitlint


##############################
Test: BuildKernel - PASS - 688.25 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 443.25 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 3.19 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 2.17 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 32.34 seconds
Run test-runner with mgmt-tester
Total: 446, Passed: 433 (97.1%), Failed: 0, Not Run: 13

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.47 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.40 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - PASS - 2.40 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: userchan-tester - PASS - 2.29 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


Attachments:
l2cap-tester.log (43.31 kB)
bnep-tester.log (3.47 kB)
mgmt-tester.log (594.25 kB)
rfcomm-tester.log (11.40 kB)
sco-tester.log (9.68 kB)
smp-tester.log (11.55 kB)
userchan-tester.log (5.33 kB)
Download all attachments

2021-06-26 05:56:55

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: hci_uart: Remove redundant assignment to fw_ptr

Hi Nigel,

> The variable fw_ptr is assigned a value that is not read and the same value
> is assigned in the patch goto. The assignment is redundant and can be
> removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Nigel Christian <[email protected]>
> ---
> drivers/bluetooth/hci_ag6xx.c | 1 -
> 1 file changed, 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel