2021-07-10 00:41:27

by Tedd Ho-Jeong An

[permalink] [raw]
Subject: [BlueZ PATCH 1/2] emulator/btdev: Add support HCI_READ_CLOCK command

From: Tedd Ho-Jeong An <[email protected]>

This patch adds support HCI_READ_CLOCK command in btdev.
---
emulator/btdev.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/emulator/btdev.c b/emulator/btdev.c
index a7fda2c89..a863a0799 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -2296,6 +2296,22 @@ static int cmd_read_rssi(struct btdev *dev, const void *data,
return 0;
}

+static int cmd_read_clock(struct btdev *dev, const void *data,
+ uint8_t len)
+{
+ const struct bt_hci_cmd_read_clock *cmd = data;
+ struct bt_hci_rsp_read_clock rsp;
+
+ memset(&rsp, 0, sizeof(rsp));
+ rsp.status = BT_HCI_ERR_SUCCESS;
+ rsp.handle = le16_to_cpu(cmd->handle);
+ rsp.clock = 0x11223344;
+ rsp.accuracy = 0x5566;
+ cmd_complete(dev, BT_HCI_CMD_READ_CLOCK, &rsp, sizeof(rsp));
+
+ return 0;
+}
+
static int cmd_enable_dut_mode(struct btdev *dev, const void *data,
uint8_t len)
{
@@ -2389,6 +2405,7 @@ static int cmd_enable_dut_mode(struct btdev *dev, const void *data,
NULL), \
CMD(BT_HCI_CMD_READ_COUNTRY_CODE, cmd_read_country_code, NULL), \
CMD(BT_HCI_CMD_READ_RSSI, cmd_read_rssi, NULL), \
+ CMD(BT_HCI_CMD_READ_CLOCK, cmd_read_clock, NULL), \
CMD(BT_HCI_CMD_ENABLE_DUT_MODE, cmd_enable_dut_mode, NULL)

static void set_common_commands_bredr20(struct btdev *btdev)
@@ -2448,6 +2465,7 @@ static void set_common_commands_bredr20(struct btdev *btdev)
btdev->commands[14] |= 0x40; /* Read Local Extended Features */
btdev->commands[15] |= 0x01; /* Read Country Code */
btdev->commands[15] |= 0x20; /* Read RSSI */
+ btdev->commands[15] |= 0x80; /* Read Clock */
btdev->commands[16] |= 0x04; /* Enable Device Under Test Mode */
}

--
2.26.3


2021-07-10 00:41:27

by Tedd Ho-Jeong An

[permalink] [raw]
Subject: [BlueZ PATCH 2/2] tool/mgmt-tester: Add test cases for Read Clock Information API

From: Brian Gix <[email protected]>

This patch adds test cases for Read Clock Information management API.
---
tools/mgmt-tester.c | 71 ++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 70 insertions(+), 1 deletion(-)

diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index d2ded574e..5def0d83c 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -3917,6 +3917,53 @@ static const struct generic_data set_privacy_nval_param_test = {
.expect_status = MGMT_STATUS_INVALID_PARAMS,
};

+static const void *get_clock_info_send_param_func(uint16_t *len)
+{
+ struct test_data *data = tester_get_data();
+ static uint8_t param[7];
+
+ memcpy(param, hciemu_get_client_bdaddr(data->hciemu), 6);
+ param[6] = 0x00; /* Address type */
+
+ *len = sizeof(param);
+
+ return param;
+}
+
+static const void *get_clock_info_expect_param_func(uint16_t *len)
+{
+ struct test_data *data = tester_get_data();
+ static uint8_t param[17];
+ struct mgmt_rp_get_clock_info *rp;
+
+ rp = (struct mgmt_rp_get_clock_info *)param;
+ memset(param, 0, sizeof(param));
+ memcpy(param, hciemu_get_client_bdaddr(data->hciemu), 6);
+ param[6] = 0x00; /* Address type */
+
+ rp->local_clock = 0x11223344;
+ rp->piconet_clock = 0x11223344;
+ rp->accuracy = 0x5566;
+
+ *len = sizeof(param);
+
+ return param;
+}
+
+static const void *get_clock_info_expect_param_not_powered_func(uint16_t *len)
+{
+ struct test_data *data = tester_get_data();
+ static uint8_t param[17];
+
+ memset(param, 0, sizeof(param));
+ memcpy(param, hciemu_get_client_bdaddr(data->hciemu), 6);
+ param[6] = 0x00; /* Address type */
+
+ *len = sizeof(param);
+
+ return param;
+}
+
static const void *get_conn_info_send_param_func(uint16_t *len)
{
struct test_data *data = tester_get_data();
@@ -3962,6 +4009,21 @@ static const void *get_conn_info_error_expect_param_func(uint16_t *len)
return param;
}

+static const struct generic_data get_clock_info_succes1_test = {
+ .setup_settings = settings_powered_connectable_bondable_ssp,
+ .send_opcode = MGMT_OP_GET_CLOCK_INFO,
+ .send_func = get_clock_info_send_param_func,
+ .expect_status = MGMT_STATUS_SUCCESS,
+ .expect_func = get_clock_info_expect_param_func,
+};
+
+static const struct generic_data get_clock_info_fail1_test = {
+ .send_opcode = MGMT_OP_GET_CLOCK_INFO,
+ .send_func = get_clock_info_send_param_func,
+ .expect_status = MGMT_STATUS_NOT_POWERED,
+ .expect_func = get_clock_info_expect_param_not_powered_func,
+};
+
static const struct generic_data get_conn_info_succes1_test = {
.setup_settings = settings_powered_connectable_bondable_ssp,
.send_opcode = MGMT_OP_GET_CONN_INFO,
@@ -9780,7 +9842,7 @@ static void test_command_generic_connect(const void *test_data)

addr_type = data->hciemu_type == HCIEMU_TYPE_BREDRLE ? BDADDR_BREDR :
BDADDR_LE_PUBLIC;
-
+ tester_print("ADDR TYPE: %d", addr_type);
bthost = hciemu_client_get_host(data->hciemu);
bthost_hci_connect(bthost, master_bdaddr, addr_type);
}
@@ -10755,6 +10817,13 @@ int main(int argc, char *argv[])
&set_privacy_nval_param_test,
NULL, test_command_generic);

+ test_bredr("Get Clock Info - Success",
+ &get_clock_info_succes1_test, NULL,
+ test_command_generic_connect);
+ test_bredrle("Get Clock Info - Fail (Power Off)",
+ &get_clock_info_fail1_test, NULL,
+ test_command_generic);
+
test_bredrle("Get Conn Info - Success",
&get_conn_info_succes1_test, NULL,
test_command_generic_connect);
--
2.26.3

2021-07-10 01:25:54

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,1/2] emulator/btdev: Add support HCI_READ_CLOCK command

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=513347

---Test result---

Test Summary:
CheckPatch PASS 0.70 seconds
GitLint PASS 0.26 seconds
Prep - Setup ELL PASS 50.85 seconds
Build - Prep PASS 0.15 seconds
Build - Configure PASS 8.96 seconds
Build - Make PASS 226.64 seconds
Make Check PASS 9.05 seconds
Make Distcheck PASS 265.15 seconds
Build w/ext ELL - Configure PASS 8.90 seconds
Build w/ext ELL - Make PASS 212.07 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth