2022-01-06 19:28:49

by Stotland, Inga

Subject: [PATCH BlueZ v2] tools/mesh-cfgclient: Fix config menu help message

An info message suggesting to request a remote node composition
should reference the correct menu command: "composition-get".
---
tools/mesh/cfgcli.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/mesh/cfgcli.c b/tools/mesh/cfgcli.c
index f815c513c..a48eace74 100644
--- a/tools/mesh/cfgcli.c
+++ b/tools/mesh/cfgcli.c
@@ -1291,7 +1291,7 @@ static void cmd_bind(uint32_t opcode, int argc, char *argv[])

if (!remote_has_composition(target)) {
bt_shell_printf("Node composition is unknown\n");
- bt_shell_printf("Call \"get-composition\" first\n");
+ bt_shell_printf("Call \"composition-get\" first\n");
return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

@@ -1493,7 +1493,7 @@ static void cmd_pub_set(int argc, char *argv[])

if (!remote_has_composition(target)) {
bt_shell_printf("Node composition is unknown\n");
- bt_shell_printf("Call \"get-composition\" first\n");
+ bt_shell_printf("Call \"composition-get\" first\n");
return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

@@ -1593,7 +1593,7 @@ static void subscription_cmd(int argc, char *argv[], uint32_t opcode)

if (!remote_has_composition(target)) {
bt_shell_printf("Node composition is unknown\n");
- bt_shell_printf("Call \"get-composition\" first\n");
+ bt_shell_printf("Call \"composition-get\" first\n");
return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

--
2.31.1

2022-01-06 21:01:07

by bluez.test.bot

Subject: RE: [BlueZ,v2] tools/mesh-cfgclient: Fix config menu help message

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=603296

---Test result---

Test Summary:
CheckPatch PASS 0.60 seconds
GitLint PASS 0.45 seconds
Prep - Setup ELL PASS 55.58 seconds
Build - Prep PASS 0.62 seconds
Build - Configure PASS 10.79 seconds
Build - Make PASS 1846.57 seconds
Make Check PASS 13.03 seconds
Make Check w/Valgrind PASS 556.91 seconds
Make Distcheck PASS 295.03 seconds
Build w/ext ELL - Configure PASS 10.80 seconds
Build w/ext ELL - Make PASS 1864.09 seconds
Incremental Build with patchesPASS 0.00 seconds



---
Regards,
Linux Bluetooth