2022-04-27 03:14:17

by quic_zijuhu

[permalink] [raw]
Subject: [PATCH v2] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA

Set HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA controllers since
they answer HCI_OP_READ_DEF_ERR_DATA_REPORTING with error code
"UNKNOWN HCI COMMAND" as shown below:

[ 580.517552] Bluetooth: hci0: unexpected cc 0x0c5a length: 1 < 2
[ 580.517660] Bluetooth: hci0: Opcode 0x c5a failed: -38

hcitool -i hci0 cmd 0x03 0x5a
< HCI Command: ogf 0x03, ocf 0x005a, plen 0
> HCI Event: 0x0e plen 4
01 5A 0C 01

btmon log:
< HCI Command: Read Default Erroneous Data Reporting (0x03|0x005a) plen 0
> HCI Event: Command Complete (0x0e) plen 4
Read Default Erroneous Data Reporting (0x03|0x005a) ncmd 1
Status: Unknown HCI Command (0x01)

Signed-off-by: Zijun Hu <[email protected]>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e6e28d3d1683..428843dbcf32 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3346,6 +3346,8 @@ static int btusb_setup_qca(struct hci_dev *hdev)
*/
set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks);

+ set_bit(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING, &hdev->quirks);
+
return 0;
}

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project


2022-04-27 09:47:57

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v2] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=635984

---Test result---

Test Summary:
CheckPatch PASS 1.64 seconds
GitLint PASS 0.97 seconds
SubjectPrefix PASS 0.88 seconds
BuildKernel PASS 31.33 seconds
BuildKernel32 PASS 27.46 seconds
Incremental Build with patchesPASS 37.87 seconds
TestRunner: Setup PASS 469.15 seconds
TestRunner: l2cap-tester PASS 17.39 seconds
TestRunner: bnep-tester PASS 6.14 seconds
TestRunner: mgmt-tester PASS 101.33 seconds
TestRunner: rfcomm-tester PASS 9.61 seconds
TestRunner: sco-tester PASS 9.48 seconds
TestRunner: smp-tester PASS 9.47 seconds
TestRunner: userchan-tester PASS 6.36 seconds



---
Regards,
Linux Bluetooth