2022-04-29 22:04:03

by bluez.test.bot

[permalink] [raw]
Subject: RE: btusb: CSR chip hangs when unbound

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=636921

---Test result---

Test Summary:
CheckPatch FAIL 2.40 seconds
GitLint FAIL 0.98 seconds
SubjectPrefix FAIL 0.83 seconds
BuildKernel PASS 40.73 seconds
BuildKernel32 PASS 36.23 seconds
Incremental Build with patchesPASS 48.50 seconds
TestRunner: Setup PASS 588.54 seconds
TestRunner: l2cap-tester PASS 19.99 seconds
TestRunner: bnep-tester PASS 7.46 seconds
TestRunner: mgmt-tester PASS 116.45 seconds
TestRunner: rfcomm-tester PASS 11.38 seconds
TestRunner: sco-tester PASS 11.05 seconds
TestRunner: smp-tester PASS 11.04 seconds
TestRunner: userchan-tester PASS 7.56 seconds

Details
##############################
Test: CheckPatch - FAIL - 2.40 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
btusb: CSR chip hangs when unbound\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#72:
for CSR chip when usb device is unbound. Besides, "skip_unconfigure" sysfs

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#94: FILE: drivers/bluetooth/btusb.c:4837:
if (le16_to_cpu(udev->descriptor.idVendor) == 0x0a12 &&
le16_to_cpu(udev->descriptor.idProduct) == 0x0001)
+ {

ERROR:CODE_INDENT: code indent should use tabs where possible
#99: FILE: drivers/bluetooth/btusb.c:4842:
+ * index 0 (unconfigure) is sent, avoid this at least$

ERROR:CODE_INDENT: code indent should use tabs where possible
#100: FILE: drivers/bluetooth/btusb.c:4843:
+ * if it is unbound */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#100: FILE: drivers/bluetooth/btusb.c:4843:
+ * if it is unbound */

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: drivers/usb/core/sysfs.c:1193:
+ struct device_attribute *attr, char *buf)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: drivers/usb/core/sysfs.c:1193:
+ struct device_attribute *attr, char *buf)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: drivers/usb/core/sysfs.c:1208:
+ struct device_attribute *attr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: drivers/usb/core/sysfs.c:1208:
+ struct device_attribute *attr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#144: FILE: drivers/usb/core/sysfs.c:1209:
+ const char *buf, size_t count)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: drivers/usb/core/sysfs.c:1209:
+ const char *buf, size_t count)$

WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
#150: FILE: drivers/usb/core/sysfs.c:1215:
+ if (sscanf(buf, "%d", &val) != 1 || val < 0 || val > 1)
+ return -EINVAL;

total: 6 errors, 6 warnings, 83 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/12831884.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL - 0.98 seconds
Run gitlint with rule in .gitlint
btusb: CSR chip hangs when unbound
7: B2 Line has trailing whitespace: "The reason is CSR chip hangs when usb configuration command with index 0 "
10: B2 Line has trailing whitespace: "To avoid this unwanted result, it is necessary not to send this command "
11: B2 Line has trailing whitespace: "for CSR chip when usb device is unbound. Besides, "skip_unconfigure" sysfs "
16: B2 Line has trailing whitespace: "On the other hand, this is not important if usb device is going to be bound "


##############################
Test: SubjectPrefix - FAIL - 0.83 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth