del_timer_sync() does not return the number of times it tried to delete the
timer which rearms itself. It's clearly documented:
The function returns whether it has deactivated a pending timer or not.
This part of the documentation is from 2003 where del_timer_sync() really
returned the number of deletion attempts for unknown reasons. The code
was rewritten in 2005, but the documentation was not updated.
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Jacob Keller <[email protected]>
---
Documentation/kernel-hacking/locking.rst | 3 +--
Documentation/translations/it_IT/kernel-hacking/locking.rst | 4 +---
2 files changed, 2 insertions(+), 5 deletions(-)
--- a/Documentation/kernel-hacking/locking.rst
+++ b/Documentation/kernel-hacking/locking.rst
@@ -1006,8 +1006,7 @@ Another common problem is deleting timer
calling add_timer() at the end of their timer function).
Because this is a fairly common case which is prone to races, you should
use del_timer_sync() (``include/linux/timer.h``) to
-handle this case. It returns the number of times the timer had to be
-deleted before we finally stopped it from adding itself back in.
+handle this case.
Locking Speed
=============
--- a/Documentation/translations/it_IT/kernel-hacking/locking.rst
+++ b/Documentation/translations/it_IT/kernel-hacking/locking.rst
@@ -1027,9 +1027,7 @@ Un altro problema è l'eliminazione dei
da soli (chiamando add_timer() alla fine della loro esecuzione).
Dato che questo è un problema abbastanza comune con una propensione
alle corse critiche, dovreste usare del_timer_sync()
-(``include/linux/timer.h``) per gestire questo caso. Questa ritorna il
-numero di volte che il temporizzatore è stato interrotto prima che
-fosse in grado di fermarlo senza che si riavviasse.
+(``include/linux/timer.h``) per gestire questo caso.
Velocità della sincronizzazione
===============================
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=698659
---Test result---
Test Summary:
CheckPatch FAIL 13.97 seconds
GitLint FAIL 5.70 seconds
SubjectPrefix FAIL 2.18 seconds
BuildKernel PASS 33.18 seconds
BuildKernel32 PASS 29.73 seconds
TestRunnerSetup PASS 422.98 seconds
TestRunner_l2cap-tester PASS 15.74 seconds
TestRunner_iso-tester PASS 15.37 seconds
TestRunner_bnep-tester PASS 5.42 seconds
TestRunner_mgmt-tester PASS 106.03 seconds
TestRunner_rfcomm-tester PASS 9.27 seconds
TestRunner_sco-tester PASS 8.73 seconds
TestRunner_ioctl-tester PASS 10.01 seconds
TestRunner_mesh-tester PASS 6.90 seconds
TestRunner_smp-tester PASS 8.53 seconds
TestRunner_userchan-tester PASS 5.64 seconds
IncrementalBuild PASS 231.92 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[V3,14/17] timers: Add shutdown mechanism to the internal functions
WARNING: 'aquisition' may be misspelled - perhaps 'acquisition'?
#139: FILE: kernel/time/timer.c:1326:
+ * aquisition. By taking the lock it is ensured that such a newly
^^^^^^^^^^
total: 0 errors, 1 warnings, 137 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13054235.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[V3,03/17] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (103>80): "[V3,03/17] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function"
[V3,04/17] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (94>80): "[V3,04/17] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function"
[V3,13/17] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode
1: T1 Title exceeds max length (81>80): "[V3,13/17] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode"
[V3,16/17] timers: Update the documentation to reflect on the new timer_shutdown() API
1: T1 Title exceeds max length (86>80): "[V3,16/17] timers: Update the documentation to reflect on the new timer_shutdown() API"
[V3,17/17] Bluetooth: hci_qca: Fix the teardown problem for real
21: B3 Line contains hard tab characters (\t): " deep in the work queue core code."
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth