2023-04-04 14:24:24

by Claudia Draghicescu

Subject: [PATCH 0/1] Set ISO Data Path on broadcast sink

This patch enables ISO data rx on broadcast sink.

Claudia Draghicescu (1):
Set ISO Data Path on broadcast sink

net/bluetooth/hci_event.c | 1 +
1 file changed, 1 insertion(+)

--
2.34.1

2023-04-04 14:24:54

by Claudia Draghicescu

Subject: [PATCH 1/1] Bluetooth: Set ISO Data Path on broadcast sink

This patch enables ISO data rx on broadcast sink.
Signed-off-by: Claudia Draghicescu <[email protected]>
---
net/bluetooth/hci_event.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 6cf9ae5b14d3..6ecd10069b6e 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -6997,6 +6997,7 @@ static void hci_le_big_sync_established_evt(struct hci_dev *hdev, void *data,
bis->iso_qos.bcast.in.latency = le16_to_cpu(ev->interval) * 125 / 100;
bis->iso_qos.bcast.in.sdu = le16_to_cpu(ev->max_pdu);

+ hci_iso_setup_path(bis);
hci_connect_cfm(bis, ev->status);
}

--
2.34.1

2023-04-04 14:59:55

by bluez.test.bot

Subject: RE: Set ISO Data Path on broadcast sink

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=736842

---Test result---

Test Summary:
CheckPatch PASS 0.68 seconds
GitLint PASS 0.33 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 32.03 seconds
CheckAllWarning PASS 34.62 seconds
CheckSparse WARNING 38.95 seconds
CheckSmatch WARNING 110.42 seconds
BuildKernel32 PASS 30.43 seconds
TestRunnerSetup PASS 434.75 seconds
TestRunner_l2cap-tester PASS 15.84 seconds
TestRunner_iso-tester PASS 15.65 seconds
TestRunner_bnep-tester PASS 5.13 seconds
TestRunner_mgmt-tester PASS 107.96 seconds
TestRunner_rfcomm-tester PASS 8.35 seconds
TestRunner_sco-tester PASS 7.45 seconds
TestRunner_ioctl-tester PASS 8.58 seconds
TestRunner_mesh-tester PASS 6.39 seconds
TestRunner_smp-tester PASS 7.38 seconds
TestRunner_userchan-tester PASS 5.31 seconds
IncrementalBuild PASS 28.63 seconds

Details
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):


---
Regards,
Linux Bluetooth

2023-04-04 18:18:05

by Luiz Augusto von Dentz

Subject: Re: [PATCH 1/1] Bluetooth: Set ISO Data Path on broadcast sink

Hi Claudia,

On Tue, Apr 4, 2023 at 7:24 AM Claudia Draghicescu <[email protected]> wrote:
>
> This patch enables ISO data rx on broadcast sink.
> Signed-off-by: Claudia Draghicescu <[email protected]>
> ---
> net/bluetooth/hci_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 6cf9ae5b14d3..6ecd10069b6e 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -6997,6 +6997,7 @@ static void hci_le_big_sync_established_evt(struct hci_dev *hdev, void *data,
> bis->iso_qos.bcast.in.latency = le16_to_cpu(ev->interval) * 125 / 100;
> bis->iso_qos.bcast.in.sdu = le16_to_cpu(ev->max_pdu);
>
> + hci_iso_setup_path(bis);
> hci_connect_cfm(bis, ev->status);

While the use of hci_iso_setup_path seems correct here we probably
need to remove hci_connect_cfm since we need to wait the result of
Data Path before signal to the socket the controller is ready to
receive data.

> }
>
> --
> 2.34.1
>


--
Luiz Augusto von Dentz