2020-12-02 21:14:25

by Stotland, Inga

Subject: [PATCH BlueZ] mesh: Zero out config node struct before initializing

This memsets all the fields of mesh_db_node to zero prior to intializing
some fields in mesh_config_node struct and creating a brand new node
configuration. Just a precaution against having uninitialized items.
---
mesh/node.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/mesh/node.c b/mesh/node.c
index 35293e0f0..4bc11309b 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -856,6 +856,8 @@ static void convert_node_to_storage(struct mesh_node *node,
{
const struct l_queue_entry *entry;

+ memset(db_node, 0, sizeof(struct mesh_config_node));
+
db_node->cid = node->comp.cid;
db_node->pid = node->comp.pid;
db_node->vid = node->comp.vid;
--
2.26.2

2020-12-02 21:27:40

by bluez.test.bot

Subject: RE: [BlueZ] mesh: Zero out config node struct before initializing

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=394959

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth

2020-12-04 18:14:27

by Gix, Brian

Subject: Re: [PATCH BlueZ] mesh: Zero out config node struct before initializing

Applied
On Wed, 2020-12-02 at 13:11 -0800, Inga Stotland wrote:
> This memsets all the fields of mesh_db_node to zero prior to intializing
> some fields in mesh_config_node struct and creating a brand new node
> configuration. Just a precaution against having uninitialized items.
> ---
> mesh/node.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mesh/node.c b/mesh/node.c
> index 35293e0f0..4bc11309b 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -856,6 +856,8 @@ static void convert_node_to_storage(struct mesh_node *node,
> {
> const struct l_queue_entry *entry;
>
> + memset(db_node, 0, sizeof(struct mesh_config_node));
> +
> db_node->cid = node->comp.cid;
> db_node->pid = node->comp.pid;
> db_node->vid = node->comp.vid;