2021-09-17 06:18:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

On 16/09/2021 20:06, [email protected] wrote:
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=548291
>
> ---Test result---
>
> Test Summary:
> CheckPatch FAIL 0.44 seconds
> GitLint PASS 0.10 seconds
> BuildKernel PASS 519.20 seconds
> TestRunner: Setup PASS 345.93 seconds
> TestRunner: l2cap-tester PASS 2.70 seconds
> TestRunner: bnep-tester PASS 1.93 seconds
> TestRunner: mgmt-tester PASS 31.31 seconds
> TestRunner: rfcomm-tester PASS 2.09 seconds
> TestRunner: sco-tester PASS 2.12 seconds
> TestRunner: smp-tester PASS 2.16 seconds
> TestRunner: userchan-tester PASS 1.95 seconds
>
> Details
> ##############################
> Test: CheckPatch - FAIL - 0.44 seconds
> Run checkpatch.pl script with rule in .checkpatch.conf
> Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible
> WARNING: Unknown commit id '81534d4835de', maybe rebased or not pulled?
> #9:
> Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")

Although you asked not to reply to this email, but you also sent it to
public mailing list, so I will reply.

Your report is incorrect. Commit ID 81534d4835de is from mainline,
merged into Linus' tree as: v5.13-rc1~94^2~197^2~38

>
> total: 0 errors, 1 warnings, 7 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> "[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt" has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.

Checkpatch does not report any warnings like that, so this is false
positive of your system, not checkpatch.



Best regards,
Krzysztof


2021-09-17 10:45:52

by Tedd Ho-Jeong An

[permalink] [raw]
Subject: Re: Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

Hi

On Thu, 2021-09-16 at 21:26 +0200, Krzysztof Kozlowski wrote:
> On 16/09/2021 20:06, [email protected] wrote:
> > This is automated email and please do not reply to this email!
> >
> > Dear submitter,
> >
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > This is a CI test results with your patch series:
> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=548291
> >
> > ---Test result---
> >
> > Test Summary:
> > CheckPatch FAIL 0.44 seconds
> > GitLint PASS 0.10 seconds
> > BuildKernel PASS 519.20 seconds
> > TestRunner: Setup PASS 345.93 seconds
> > TestRunner: l2cap-tester PASS 2.70 seconds
> > TestRunner: bnep-tester PASS 1.93 seconds
> > TestRunner: mgmt-tester PASS 31.31 seconds
> > TestRunner: rfcomm-tester PASS 2.09 seconds
> > TestRunner: sco-tester PASS 2.12 seconds
> > TestRunner: smp-tester PASS 2.16 seconds
> > TestRunner: userchan-tester PASS 1.95 seconds
> >
> > Details
> > ##############################
> > Test: CheckPatch - FAIL - 0.44 seconds
> > Run checkpatch.pl script with rule in .checkpatch.conf
> > Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible
> > WARNING: Unknown commit id '81534d4835de', maybe rebased or not pulled?
> > #9:
> > Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")
>
> Although you asked not to reply to this email, but you also sent it to
> public mailing list, so I will reply.
>
> Your report is incorrect. Commit ID 81534d4835de is from mainline,
> merged into Linus' tree as: v5.13-rc1~94^2~197^2~38
>
> > total: 0 errors, 1 warnings, 7 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> > mechanically convert to the typical style using --fix or --fix-inplace.
> >
> > "[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt" has style problems, please
> > review.
> >
> > NOTE: If any of the errors are false positives, please report
> > them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Checkpatch does not report any warnings like that, so this is false
> positive of your system, not checkpatch.
>
It is a known issue and will be fixed soon.
Sorry for the trouble.


>
>
> Best regards,
> Krzysztof

Regards,
Tedd