2020-09-12 06:40:07

by Tedd Ho-Jeong An

[permalink] [raw]
Subject: [BlueZ 13/17] plugins: Add SPDX License Identifer

From: Tedd Ho-Jeong An <[email protected]>

This patch adds SPDX License Identifier.

-------------------------------------
License COUNT
-------------------------------------
GPL-2.0-or-later : 7

License: GPL-2.0-or-later
plugins/autopair.c
plugins/hostname.c
plugins/neard.c
plugins/policy.c
plugins/sixaxis.c
plugins/wiimote.c
plugins/external-dummy.c
---
plugins/autopair.c | 1 +
plugins/external-dummy.c | 1 +
plugins/hostname.c | 1 +
plugins/neard.c | 1 +
plugins/policy.c | 1 +
plugins/sixaxis.c | 1 +
plugins/wiimote.c | 1 +
7 files changed, 7 insertions(+)

diff --git a/plugins/autopair.c b/plugins/autopair.c
index 3089430a8..381d91c8f 100644
--- a/plugins/autopair.c
+++ b/plugins/autopair.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
diff --git a/plugins/external-dummy.c b/plugins/external-dummy.c
index 536ad0663..78377b021 100644
--- a/plugins/external-dummy.c
+++ b/plugins/external-dummy.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
diff --git a/plugins/hostname.c b/plugins/hostname.c
index 4f9dfe6d8..32f15b3a5 100644
--- a/plugins/hostname.c
+++ b/plugins/hostname.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
diff --git a/plugins/neard.c b/plugins/neard.c
index 6ffcd6e10..1fefc5015 100644
--- a/plugins/neard.c
+++ b/plugins/neard.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
diff --git a/plugins/policy.c b/plugins/policy.c
index de51e58b9..86eb25ee9 100644
--- a/plugins/policy.c
+++ b/plugins/policy.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 939fed759..8350d63f8 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
diff --git a/plugins/wiimote.c b/plugins/wiimote.c
index 0ced27514..9441a7681 100644
--- a/plugins/wiimote.c
+++ b/plugins/wiimote.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
*
* BlueZ - Bluetooth protocol stack for Linux
--
2.25.4


2020-09-14 17:35:42

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [BlueZ 13/17] plugins: Add SPDX License Identifer

Hi Tedd,

On Fri, Sep 11, 2020 at 11:41 PM <[email protected]> wrote:
>
> From: Tedd Ho-Jeong An <[email protected]>
>
> This patch adds SPDX License Identifier.
>
> -------------------------------------
> License COUNT
> -------------------------------------
> GPL-2.0-or-later : 7

I guess all GPL 2.0 or later can be updated to GPL 2.1 or later.

> License: GPL-2.0-or-later
> plugins/autopair.c
> plugins/hostname.c
> plugins/neard.c
> plugins/policy.c
> plugins/sixaxis.c
> plugins/wiimote.c
> plugins/external-dummy.c
> ---
> plugins/autopair.c | 1 +
> plugins/external-dummy.c | 1 +
> plugins/hostname.c | 1 +
> plugins/neard.c | 1 +
> plugins/policy.c | 1 +
> plugins/sixaxis.c | 1 +
> plugins/wiimote.c | 1 +
> 7 files changed, 7 insertions(+)
>
> diff --git a/plugins/autopair.c b/plugins/autopair.c
> index 3089430a8..381d91c8f 100644
> --- a/plugins/autopair.c
> +++ b/plugins/autopair.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Why are you using C++ // comments on the .c files and /* */ comments
on .h? Also it looks like you are keeping the old license text which
should no longer be necessary.

> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/external-dummy.c b/plugins/external-dummy.c
> index 536ad0663..78377b021 100644
> --- a/plugins/external-dummy.c
> +++ b/plugins/external-dummy.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/hostname.c b/plugins/hostname.c
> index 4f9dfe6d8..32f15b3a5 100644
> --- a/plugins/hostname.c
> +++ b/plugins/hostname.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/neard.c b/plugins/neard.c
> index 6ffcd6e10..1fefc5015 100644
> --- a/plugins/neard.c
> +++ b/plugins/neard.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/policy.c b/plugins/policy.c
> index de51e58b9..86eb25ee9 100644
> --- a/plugins/policy.c
> +++ b/plugins/policy.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
> index 939fed759..8350d63f8 100644
> --- a/plugins/sixaxis.c
> +++ b/plugins/sixaxis.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/wiimote.c b/plugins/wiimote.c
> index 0ced27514..9441a7681 100644
> --- a/plugins/wiimote.c
> +++ b/plugins/wiimote.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> --
> 2.25.4
>


--
Luiz Augusto von Dentz

2020-09-14 20:27:42

by An, Tedd

[permalink] [raw]
Subject: Re: [BlueZ 13/17] plugins: Add SPDX License Identifer

Hi Luiz,

I realized that there is no GPL 2.1 or later.

Only for LGPL 2.1 or later...
I will keep as is.

Regards,
Tedd

On 9/14/20, 10:33 AM, "Luiz Augusto von Dentz" <[email protected]> wrote:

Hi Tedd,

On Fri, Sep 11, 2020 at 11:41 PM <[email protected]> wrote:
>
> From: Tedd Ho-Jeong An <[email protected]>
>
> This patch adds SPDX License Identifier.
>
> -------------------------------------
> License COUNT
> -------------------------------------
> GPL-2.0-or-later : 7

I guess all GPL 2.0 or later can be updated to GPL 2.1 or later.

> License: GPL-2.0-or-later
> plugins/autopair.c
> plugins/hostname.c
> plugins/neard.c
> plugins/policy.c
> plugins/sixaxis.c
> plugins/wiimote.c
> plugins/external-dummy.c
> ---
> plugins/autopair.c | 1 +
> plugins/external-dummy.c | 1 +
> plugins/hostname.c | 1 +
> plugins/neard.c | 1 +
> plugins/policy.c | 1 +
> plugins/sixaxis.c | 1 +
> plugins/wiimote.c | 1 +
> 7 files changed, 7 insertions(+)
>
> diff --git a/plugins/autopair.c b/plugins/autopair.c
> index 3089430a8..381d91c8f 100644
> --- a/plugins/autopair.c
> +++ b/plugins/autopair.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Why are you using C++ // comments on the .c files and /* */ comments
on .h? Also it looks like you are keeping the old license text which
should no longer be necessary.

> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/external-dummy.c b/plugins/external-dummy.c
> index 536ad0663..78377b021 100644
> --- a/plugins/external-dummy.c
> +++ b/plugins/external-dummy.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/hostname.c b/plugins/hostname.c
> index 4f9dfe6d8..32f15b3a5 100644
> --- a/plugins/hostname.c
> +++ b/plugins/hostname.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/neard.c b/plugins/neard.c
> index 6ffcd6e10..1fefc5015 100644
> --- a/plugins/neard.c
> +++ b/plugins/neard.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/policy.c b/plugins/policy.c
> index de51e58b9..86eb25ee9 100644
> --- a/plugins/policy.c
> +++ b/plugins/policy.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
> index 939fed759..8350d63f8 100644
> --- a/plugins/sixaxis.c
> +++ b/plugins/sixaxis.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> diff --git a/plugins/wiimote.c b/plugins/wiimote.c
> index 0ced27514..9441a7681 100644
> --- a/plugins/wiimote.c
> +++ b/plugins/wiimote.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> *
> * BlueZ - Bluetooth protocol stack for Linux
> --
> 2.25.4
>


--
Luiz Augusto von Dentz