2021-03-30 18:41:23

by Sonny Sasaka

[permalink] [raw]
Subject: [PATCH BlueZ] profiles/battery: Reset battery value cache on disconnect

Due to cache in batt object, bluetoothd fails to update publish the
battery value after reconnection when the battery value does not change
compared to before reconnection. We should reset the battery percentage
cache on disconnect.

Reviewed-by: Alain Michaud <[email protected]>

---
profiles/battery/battery.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/profiles/battery/battery.c b/profiles/battery/battery.c
index 81f849d57..176d127f6 100644
--- a/profiles/battery/battery.c
+++ b/profiles/battery/battery.c
@@ -75,6 +75,7 @@ static void batt_free(struct batt *batt)
static void batt_reset(struct batt *batt)
{
batt->attr = NULL;
+ batt->percentage = -1;
gatt_db_unref(batt->db);
batt->db = NULL;
bt_gatt_client_unref(batt->client);
--
2.29.2


2021-03-30 18:57:26

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ] profiles/battery: Reset battery value cache on disconnect

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=458277

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild: Setup ELL - PASS

##############################
Test: CheckBuild: Setup - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS

##############################
Test: CheckBuild w/external ell - PASS



---
Regards,
Linux Bluetooth

2021-03-30 19:28:38

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [BlueZ] profiles/battery: Reset battery value cache on disconnect

Hi Sonny,

On Tue, Mar 30, 2021 at 11:57 AM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=458277
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild: Setup ELL - PASS
>
> ##############################
> Test: CheckBuild: Setup - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
> ##############################
> Test: CheckBuild w/external ell - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

--
Luiz Augusto von Dentz