2020-03-20 05:16:11

by Archie Pusaka

Subject: [Bluez PATCH v1] avdtp: fix delay report valid states

From: Archie Pusaka <[email protected]>

According to AVDTP specification section 6.19,
avdtp_delayreport_cmd could also be received when the state of SEP
is open.

Therefore, updating to accommodate such condition.
---

profiles/audio/avdtp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 0e075f9ff..4b0e63384 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
stream = sep->stream;

if (sep->state != AVDTP_STATE_CONFIGURED &&
+ sep->state != AVDTP_STATE_OPEN &&
sep->state != AVDTP_STATE_STREAMING) {
err = AVDTP_BAD_STATE;
goto failed;
--
2.25.1.696.g5e7596f4ac-goog

2020-03-27 02:15:25

by Archie Pusaka

Subject: Re: [Bluez PATCH v1] avdtp: fix delay report valid states

[re-sending as plain text]
Hi Bluez Maintainers,

Could you take a look at this proposal?

Thank you!


On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <[email protected]> wrote:
>
> From: Archie Pusaka <[email protected]>
>
> According to AVDTP specification section 6.19,
> avdtp_delayreport_cmd could also be received when the state of SEP
> is open.
>
> Therefore, updating to accommodate such condition.
> ---
>
> profiles/audio/avdtp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> index 0e075f9ff..4b0e63384 100644
> --- a/profiles/audio/avdtp.c
> +++ b/profiles/audio/avdtp.c
> @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
> stream = sep->stream;
>
> if (sep->state != AVDTP_STATE_CONFIGURED &&
> + sep->state != AVDTP_STATE_OPEN &&
> sep->state != AVDTP_STATE_STREAMING) {
> err = AVDTP_BAD_STATE;
> goto failed;
> --
> 2.25.1.696.g5e7596f4ac-goog
>

2020-03-27 20:57:31

by Luiz Augusto von Dentz

Subject: Re: [Bluez PATCH v1] avdtp: fix delay report valid states

Hi Archie,

On Thu, Mar 26, 2020 at 7:14 PM Archie Pusaka <[email protected]> wrote:
>
> [re-sending as plain text]
> Hi Bluez Maintainers,
>
> Could you take a look at this proposal?
>
> Thank you!
>
>
> On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <[email protected]> wrote:
> >
> > From: Archie Pusaka <[email protected]>
> >
> > According to AVDTP specification section 6.19,
> > avdtp_delayreport_cmd could also be received when the state of SEP
> > is open.
> >
> > Therefore, updating to accommodate such condition.
> > ---
> >
> > profiles/audio/avdtp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> > index 0e075f9ff..4b0e63384 100644
> > --- a/profiles/audio/avdtp.c
> > +++ b/profiles/audio/avdtp.c
> > @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
> > stream = sep->stream;
> >
> > if (sep->state != AVDTP_STATE_CONFIGURED &&
> > + sep->state != AVDTP_STATE_OPEN &&
> > sep->state != AVDTP_STATE_STREAMING) {
> > err = AVDTP_BAD_STATE;
> > goto failed;
> > --
> > 2.25.1.696.g5e7596f4ac-goog
> >

Applied, thanks.

--
Luiz Augusto von Dentz