2020-03-09 21:48:48

by Marcel Holtmann

Subject: [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message

When the RPA generation fails, indicate the error with a device specifc
error message.

Signed-off-by: Marcel Holtmann <[email protected]>
---
net/bluetooth/hci_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index 2a1b64dbf76e..53179ae856ae 100644
--- a/net/bluetooth/hci_request.c
+++ b/net/bluetooth/hci_request.c
@@ -1499,7 +1499,7 @@ int hci_get_random_address(struct hci_dev *hdev, bool require_privacy,

err = smp_generate_rpa(hdev, hdev->irk, &hdev->rpa);
if (err < 0) {
- BT_ERR("%s failed to generate new RPA", hdev->name);
+ bt_dev_err(hdev, "failed to generate new RPA");
return err;
}

--
2.24.1

2020-03-10 15:12:40

by Alain Michaud

Subject: Re: [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message

Hi Marcel,


On Mon, Mar 9, 2020 at 5:48 PM Marcel Holtmann <[email protected]> wrote:
>
> When the RPA generation fails, indicate the error with a device specifc
> error message.
>
> Signed-off-by: Marcel Holtmann <[email protected]>
> ---
> net/bluetooth/hci_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 2a1b64dbf76e..53179ae856ae 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -1499,7 +1499,7 @@ int hci_get_random_address(struct hci_dev *hdev, bool require_privacy,
>
> err = smp_generate_rpa(hdev, hdev->irk, &hdev->rpa);
> if (err < 0) {
> - BT_ERR("%s failed to generate new RPA", hdev->name);
> + bt_dev_err(hdev, "failed to generate new RPA");
> return err;
> }
>
> --
> 2.24.1
>

LGTM.

2020-03-11 08:08:08

by Johan Hedberg

Subject: Re: [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message

Hi Marcel,

On Mon, Mar 09, 2020, Marcel Holtmann wrote:
> When the RPA generation fails, indicate the error with a device specifc
> error message.
>
> Signed-off-by: Marcel Holtmann <[email protected]>
> ---
> net/bluetooth/hci_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to bluetooth-next. Thanks.

Johan