2023-02-06 12:06:22

by Herbert Xu

Subject: [PATCH 17/17] crypto: api - Remove completion function scaffolding

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.

Signed-off-by: Herbert Xu <[email protected]>
---

include/linux/crypto.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/include/linux/crypto.h b/include/linux/crypto.h
index 80f6350fb588..bb1d9b0e1647 100644
--- a/include/linux/crypto.h
+++ b/include/linux/crypto.h
@@ -176,7 +176,6 @@ struct crypto_async_request;
struct crypto_tfm;
struct crypto_type;

-typedef void crypto_completion_data_t;
typedef void (*crypto_completion_t)(void *req, int err);

/**
@@ -596,11 +595,6 @@ struct crypto_wait {
/*
* Async ops completion helper functioons
*/
-static inline void *crypto_get_completion_data(void *data)
-{
- return data;
-}
-
void crypto_req_done(void *req, int err);

static inline int crypto_wait_req(int err, struct crypto_wait *wait)

2023-02-10 00:58:45

by Jarkko Sakkinen

Subject: Re: [PATCH 17/17] crypto: api - Remove completion function scaffolding

On Mon, Feb 06, 2023 at 06:22:46PM +0800, Herbert Xu wrote:
> This patch removes the temporary scaffolding now that the comletion
> function signature has been converted.
>
> Signed-off-by: Herbert Xu <[email protected]>

For the 1-17:

Acked-by: Jarkko Sakkinen <[email protected]>

(nit applies tho to all of them but use your own judgement i guess)

> ---
>
> include/linux/crypto.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index 80f6350fb588..bb1d9b0e1647 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -176,7 +176,6 @@ struct crypto_async_request;
> struct crypto_tfm;
> struct crypto_type;
>
> -typedef void crypto_completion_data_t;
> typedef void (*crypto_completion_t)(void *req, int err);
>
> /**
> @@ -596,11 +595,6 @@ struct crypto_wait {
> /*
> * Async ops completion helper functioons
> */
> -static inline void *crypto_get_completion_data(void *data)
> -{
> - return data;
> -}
> -
> void crypto_req_done(void *req, int err);
>
> static inline int crypto_wait_req(int err, struct crypto_wait *wait)

BR, Jarkko