2020-09-03 19:02:49

by Stotland, Inga

Subject: [PATCH BlueZ] mesh: Remove unused timing variable tx_start

In model.c, tx_Start is a static variable, dynamically set, but
never used. Is removed now.
---
mesh/model.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/mesh/model.c b/mesh/model.c
index ed2a75215..5716f5e22 100644
--- a/mesh/model.c
+++ b/mesh/model.c
@@ -80,8 +80,6 @@ struct mod_forward {

static struct l_queue *mesh_virtuals;

-static struct timeval tx_start;
-
static bool is_internal(uint32_t id)
{
if (id == CONFIG_SRV_MODEL || id == CONFIG_CLI_MODEL)
@@ -1018,8 +1016,6 @@ int mesh_model_publish(struct mesh_node *node, uint32_t id, uint16_t src,
return MESH_ERROR_DOES_NOT_EXIST;
}

- gettimeofday(&tx_start, NULL);
-
if (IS_UNASSIGNED(mod->pub->addr))
return MESH_ERROR_DOES_NOT_EXIST;

@@ -1049,8 +1045,6 @@ bool mesh_model_send(struct mesh_node *node, uint16_t src, uint16_t dst,
if (src == 0)
src = node_get_primary(node);

- gettimeofday(&tx_start, NULL);
-
if (IS_UNASSIGNED(dst))
return false;

--
2.26.2

2020-09-03 20:30:23

by Gix, Brian

Subject: Re: [PATCH BlueZ] mesh: Remove unused timing variable tx_start

Applied
On Thu, 2020-09-03 at 12:02 -0700, Inga Stotland wrote:
> In model.c, tx_Start is a static variable, dynamically set, but
> never used. Is removed now.
> ---
> mesh/model.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/mesh/model.c b/mesh/model.c
> index ed2a75215..5716f5e22 100644
> --- a/mesh/model.c
> +++ b/mesh/model.c
> @@ -80,8 +80,6 @@ struct mod_forward {
>
> static struct l_queue *mesh_virtuals;
>
> -static struct timeval tx_start;
> -
> static bool is_internal(uint32_t id)
> {
> if (id == CONFIG_SRV_MODEL || id == CONFIG_CLI_MODEL)
> @@ -1018,8 +1016,6 @@ int mesh_model_publish(struct mesh_node *node, uint32_t id, uint16_t src,
> return MESH_ERROR_DOES_NOT_EXIST;
> }
>
> - gettimeofday(&tx_start, NULL);
> -
> if (IS_UNASSIGNED(mod->pub->addr))
> return MESH_ERROR_DOES_NOT_EXIST;
>
> @@ -1049,8 +1045,6 @@ bool mesh_model_send(struct mesh_node *node, uint16_t src, uint16_t dst,
> if (src == 0)
> src = node_get_primary(node);
>
> - gettimeofday(&tx_start, NULL);
> -
> if (IS_UNASSIGNED(dst))
> return false;
>