Hello list,
some time ago my company tasked me to develop this feature, but
unfortunately they changed their mind before I could complete
development. I sought to finish it on my own, but my spare time is
dwindling lately.
So I thought that someone might be interested to pick development up
where I left it off.
If anyone is interested, I'm willing to provide the source code of my
own work. I implemented it for HSP up to the actual creation of audio
channels (excluded). Mostly implemented and working is rfcomm
connection and event passing ("RING", ...).
My modifications are made against bluez-3.36 (latest version of the
3.x branch), but I think it should be trivial to forward port them to
bluez 4 (if you have a look at audio/gateway.c you will notice there
is nothing in there), so I would provide a patch that applies against
that codebase.
Best regards,
Michele Noberasco
On Thu, Jan 29, 2009 at 10:34, Michele Noberasco
<[email protected]> wrote:
> Il giorno 28/gen/09, alle ore 06:54, Marcel Holtmann ha scritto:
>
>> Hi Michele,
>
> Hello Marcel
>
>> I like you two guys work together and send patches against BlueZ 4.x to
>> add the headset roles. Please split the work in smaller patches so we
>> can actually review it. Big chunks are always hard to chew and time
>> consuming. The quicker either Johan, Luiz or me can go through the code
>> the quicker we can merge it.
>
> Sorry to disappoint you, but my patch is against BlueZ 3 and nowhere near
> completion ;-)
> As I said, it is provided 'as is' since unfortunately I have to more time to
> spend on it :-(
>
> Leonid: was my code of any use to you?
>
> Regards,
> Michele Noberasco
>
>
Hello Michele,
Saying honestly - no :). I've already implemented the functionality
found in your patch. But thank you anyhow.
Vale,
Leonid Movshovich
Il giorno 28/gen/09, alle ore 06:54, Marcel Holtmann ha scritto:
> Hi Michele,
Hello Marcel
> I like you two guys work together and send patches against BlueZ 4.x
> to
> add the headset roles. Please split the work in smaller patches so we
> can actually review it. Big chunks are always hard to chew and time
> consuming. The quicker either Johan, Luiz or me can go through the
> code
> the quicker we can merge it.
Sorry to disappoint you, but my patch is against BlueZ 3 and nowhere
near completion ;-)
As I said, it is provided 'as is' since unfortunately I have to more
time to spend on it :-(
Leonid: was my code of any use to you?
Regards,
Michele Noberasco
Hi Michele,
> > I'm doing the same function just now :).
> > So please send your code and I will look there for something I've
> > missed.
>
> Glad that my partial work might be of help.
> Here it is...
I like you two guys work together and send patches against BlueZ 4.x to
add the headset roles. Please split the work in smaller patches so we
can actually review it. Big chunks are always hard to chew and time
consuming. The quicker either Johan, Luiz or me can go through the code
the quicker we can merge it.
Regards
Marcel
Il giorno 23/gen/09, alle ore 08:34, event ha scritto:
> Hello Michele,
>
> I'm doing the same function just now :).
> So please send your code and I will look there for something I've
> missed.
Glad that my partial work might be of help.
Here it is...
Regards,
Michele Noberasco
On Thu, Jan 22, 2009 at 18:43, Michele Noberasco
<[email protected]> wrote:
> Hello list,
>
> some time ago my company tasked me to develop this feature, but
> unfortunately they changed their mind before I could complete development. I
> sought to finish it on my own, but my spare time is dwindling lately.
>
> So I thought that someone might be interested to pick development up where I
> left it off.
>
> If anyone is interested, I'm willing to provide the source code of my own
> work. I implemented it for HSP up to the actual creation of audio channels
> (excluded). Mostly implemented and working is rfcomm connection and event
> passing ("RING", ...).
>
> My modifications are made against bluez-3.36 (latest version of the 3.x
> branch), but I think it should be trivial to forward port them to bluez 4
> (if you have a look at audio/gateway.c you will notice there is nothing in
> there), so I would provide a patch that applies against that codebase.
>
> Best regards,
> Michele Noberasco
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
> in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hello Michele,
I'm doing the same function just now :).
So please send your code and I will look there for something I've missed.
Vale,
Leonid Movshovich
On Mon, Feb 9, 2009 at 07:38, Zhao Forrest <[email protected]> wrote:
>>>>>
>>>>>
>>>>
>>>> Hello Michele,
>>>>
>>>> Saying honestly - no :). I've already implemented the functionality
>>>> found in your patch. But thank you anyhow.
>>>>
>>> Event,
>>> What's the current status of your patch? Is it still pending on main BlueZ
>>> developer's review? If this is the case I think that you split the big
>>> patch into
>>> small pieces could make the code review process more smooth :)
>>>
>>> Thanks,
>>> Forrest
>>>
>> Hello Zhao,
>>
>> Unfortunately, I don't have time currently to work on this.
> Do you mind if we pick up your patch and divide it into smaller pieces
> to try to push
> it into BlueZ upstream?
>
> Thanks,
> Forrest
>
Hello Forrest,
Yes, I would be pleased if you'll take it :)
Vale,
Leonid Movshovich
>>>>
>>>>
>>>
>>> Hello Michele,
>>>
>>> Saying honestly - no :). I've already implemented the functionality
>>> found in your patch. But thank you anyhow.
>>>
>> Event,
>> What's the current status of your patch? Is it still pending on main BlueZ
>> developer's review? If this is the case I think that you split the big
>> patch into
>> small pieces could make the code review process more smooth :)
>>
>> Thanks,
>> Forrest
>>
> Hello Zhao,
>
> Unfortunately, I don't have time currently to work on this.
Do you mind if we pick up your patch and divide it into smaller pieces
to try to push
it into BlueZ upstream?
Thanks,
Forrest
On Thu, Feb 5, 2009 at 07:06, Zhao Forrest <[email protected]> wrote:
> On Thu, Jan 29, 2009 at 4:46 PM, event <[email protected]> wrote:
>> On Thu, Jan 29, 2009 at 10:34, Michele Noberasco
>> <[email protected]> wrote:
>>> Il giorno 28/gen/09, alle ore 06:54, Marcel Holtmann ha scritto:
>>>
>>>> Hi Michele,
>>>
>>> Hello Marcel
>>>
>>>> I like you two guys work together and send patches against BlueZ 4.x to
>>>> add the headset roles. Please split the work in smaller patches so we
>>>> can actually review it. Big chunks are always hard to chew and time
>>>> consuming. The quicker either Johan, Luiz or me can go through the code
>>>> the quicker we can merge it.
>>>
>>> Sorry to disappoint you, but my patch is against BlueZ 3 and nowhere near
>>> completion ;-)
>>> As I said, it is provided 'as is' since unfortunately I have to more time to
>>> spend on it :-(
>>>
>>> Leonid: was my code of any use to you?
>>>
>>> Regards,
>>> Michele Noberasco
>>>
>>>
>>
>> Hello Michele,
>>
>> Saying honestly - no :). I've already implemented the functionality
>> found in your patch. But thank you anyhow.
>>
> Event,
> What's the current status of your patch? Is it still pending on main BlueZ
> developer's review? If this is the case I think that you split the big
> patch into
> small pieces could make the code review process more smooth :)
>
> Thanks,
> Forrest
>
Hello Zhao,
Unfortunately, I don't have time currently to work on this.
Vale,
Leonid Movshovich
On Thu, Jan 29, 2009 at 4:46 PM, event <[email protected]> wrote:
> On Thu, Jan 29, 2009 at 10:34, Michele Noberasco
> <[email protected]> wrote:
>> Il giorno 28/gen/09, alle ore 06:54, Marcel Holtmann ha scritto:
>>
>>> Hi Michele,
>>
>> Hello Marcel
>>
>>> I like you two guys work together and send patches against BlueZ 4.x to
>>> add the headset roles. Please split the work in smaller patches so we
>>> can actually review it. Big chunks are always hard to chew and time
>>> consuming. The quicker either Johan, Luiz or me can go through the code
>>> the quicker we can merge it.
>>
>> Sorry to disappoint you, but my patch is against BlueZ 3 and nowhere near
>> completion ;-)
>> As I said, it is provided 'as is' since unfortunately I have to more time to
>> spend on it :-(
>>
>> Leonid: was my code of any use to you?
>>
>> Regards,
>> Michele Noberasco
>>
>>
>
> Hello Michele,
>
> Saying honestly - no :). I've already implemented the functionality
> found in your patch. But thank you anyhow.
>
Event,
What's the current status of your patch? Is it still pending on main BlueZ
developer's review? If this is the case I think that you split the big
patch into
small pieces could make the code review process more smooth :)
Thanks,
Forrest