2022-04-12 07:56:26

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH BlueZ] btdev: Fix not cleanup ssp_status and ssp_auto_complete

Dear Luiz,


Thank you for your patch.

Am 12.04.22 um 01:58 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This fixes not clenup ssp_status and ssp_auto_complete flags on

cle*a*nup

> auth_complete.

I’d just write:

Clean up ssp_status and ssp_auto_complete flags on auth_complete

(Same for the commit message summary.)

> ---
> emulator/btdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index f70fa9136..ccfaed36b 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -1366,6 +1366,11 @@ static void auth_complete(struct btdev_conn *conn, uint8_t status)
> ev.status = status;
>
> send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev));
> +
> + conn->dev->ssp_status = 0;
> + conn->dev->ssp_auth_complete = false;
> + conn->link->dev->ssp_status = 0;
> + conn->link->dev->ssp_auth_complete = false;
> }
>
> static int cmd_link_key_reply_complete(struct btdev *dev, const void *data,

Acked-by: Paul Menzel <[email protected]>


Kind regards,

Paul