2021-05-19 20:20:37

by Tedd Ho-Jeong An

Subject: Re: [PATCH BlueZ v2 1/5] mesh: Fix delivery of PB-ACK to acceptors

Hi Brian,

On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:
> Rwmove unneeded initialization that prevented the Acceptor roll of ever

Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".

> recognizing a valid PB-ACK.
> ---
> mesh/pb-adv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
> index c74dae79f..83f922aa8 100644
> --- a/mesh/pb-adv.c
> +++ b/mesh/pb-adv.c
> @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
> first = !session->link_id;
> session->link_id = link_id;
> session->last_peer_trans_num = 0xFF;
> - session->local_acked = 0xFF;
> session->peer_trans_num = 0x00;
> session->local_trans_num = 0x7F;
> session->opened = true;

Regards,
Tedd

2021-05-19 20:20:55

by Gix, Brian

Subject: Re: [PATCH BlueZ v2 1/5] mesh: Fix delivery of PB-ACK to acceptors

On Wed, 2021-05-19 at 11:30 -0700, Tedd Ho-Jeong An wrote:
> Hi Brian,
>
> On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:
> > Rwmove unneeded initialization that prevented the Acceptor roll of ever
>
> Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".

Thanks Tedd -- If no other issues are found, I will fix when it is applied.

> > recognizing a valid PB-ACK.
> > ---
> > mesh/pb-adv.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
> > index c74dae79f..83f922aa8 100644
> > --- a/mesh/pb-adv.c
> > +++ b/mesh/pb-adv.c
> > @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
> > first = !session->link_id;
> > session->link_id = link_id;
> > session->last_peer_trans_num = 0xFF;
> > - session->local_acked = 0xFF;
> > session->peer_trans_num = 0x00;
> > session->local_trans_num = 0x7F;
> > session->opened = true;
>
> Regards,
> Tedd
>