From: Luiz Augusto von Dentz <[email protected]>
set_mode shall use opcode to identify what setting are being changed
rather then the mode.
---
src/adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/adapter.c b/src/adapter.c
index 051c32753..f483cc827 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -631,7 +631,7 @@ static bool set_mode(struct btd_adapter *adapter, uint16_t opcode,
memset(&cp, 0, sizeof(cp));
cp.val = mode;
- switch (mode) {
+ switch (opcode) {
case MGMT_OP_SET_POWERED:
setting = MGMT_SETTING_POWERED;
break;
--
2.29.2
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=442263
---Test result---
##############################
Test: CheckPatch - PASS
##############################
Test: CheckGitLint - PASS
##############################
Test: CheckBuild - PASS
##############################
Test: MakeCheck - PASS
---
Regards,
Linux Bluetooth
On Thu, 2021-03-04 at 14:24 -0800, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> set_mode shall use opcode to identify what setting are being changed
> rather then the mode.
What was the symptom of this bug?
> ---
> src/adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 051c32753..f483cc827 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -631,7 +631,7 @@ static bool set_mode(struct btd_adapter *adapter,
> uint16_t opcode,
> memset(&cp, 0, sizeof(cp));
> cp.val = mode;
>
> - switch (mode) {
> + switch (opcode) {
> case MGMT_OP_SET_POWERED:
> setting = MGMT_SETTING_POWERED;
> break;
Hi,
On Thu, Mar 4, 2021 at 2:38 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=442263
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth
Applied.
--
Luiz Augusto von Dentz
On Fri, 2021-03-05 at 17:17 -0800, Luiz Augusto von Dentz wrote:
> Hi,
>
> On Thu, Mar 4, 2021 at 2:38 PM <[email protected]> wrote:
> >
> > This is automated email and please do not reply to this email!
> >
> > Dear submitter,
> >
> > Thank you for submitting the patches to the linux bluetooth mailing
> > list.
> > This is a CI test results with your patch series:
> > PW Link:
> > https://patchwork.kernel.org/project/bluetooth/list/?series=442263
> >
> > ---Test result---
> >
> > ##############################
> > Test: CheckPatch - PASS
> >
> > ##############################
> > Test: CheckGitLint - PASS
> >
> > ##############################
> > Test: CheckBuild - PASS
> >
> > ##############################
> > Test: MakeCheck - PASS
> >
> >
> >
> > ---
> > Regards,
> > Linux Bluetooth
>
> Applied.
You didn't reply to my question about the patch.
I can't wait until we don't have to use mailing-lists to submit
patches.
Sigh.