If HID_SUPPORT is not selected, BT_HIDP should not be available, simply
because we disallowed the HID bus entirely.
Add a new depends and actually revert this file back to where it was 10
years ago before it was changed by commit 1f41a6a99476 ("HID: Fix the
generic Kconfig options").
Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Benjamin Tissoires <[email protected]>
---
net/bluetooth/hidp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
index 14100f341f33..6746be07e222 100644
--- a/net/bluetooth/hidp/Kconfig
+++ b/net/bluetooth/hidp/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config BT_HIDP
tristate "HIDP protocol support"
- depends on BT_BREDR && INPUT
+ depends on BT_BREDR && INPUT && HID_SUPPORT
select HID
help
HIDP (Human Interface Device Protocol) is a transport layer
--
2.38.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696819
---Test result---
Test Summary:
CheckPatch PASS 0.65 seconds
GitLint PASS 0.35 seconds
SubjectPrefix FAIL 0.33 seconds
BuildKernel PASS 33.09 seconds
BuildKernel32 PASS 29.58 seconds
TestRunnerSetup PASS 423.99 seconds
TestRunner_l2cap-tester PASS 16.41 seconds
TestRunner_iso-tester PASS 15.58 seconds
TestRunner_bnep-tester PASS 5.57 seconds
TestRunner_mgmt-tester PASS 106.35 seconds
TestRunner_rfcomm-tester PASS 9.50 seconds
TestRunner_sco-tester PASS 9.00 seconds
TestRunner_ioctl-tester PASS 10.26 seconds
TestRunner_mesh-tester PASS 7.09 seconds
TestRunner_smp-tester PASS 8.78 seconds
TestRunner_userchan-tester PASS 5.89 seconds
IncrementalBuild PASS 30.89 seconds
Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth
On Fri, 18 Nov 2022, Benjamin Tissoires wrote:
> If HID_SUPPORT is not selected, BT_HIDP should not be available, simply
> because we disallowed the HID bus entirely.
>
> Add a new depends and actually revert this file back to where it was 10
> years ago before it was changed by commit 1f41a6a99476 ("HID: Fix the
> generic Kconfig options").
>
> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]/
> Signed-off-by: Benjamin Tissoires <[email protected]>
Applied to for-6.2/hid-bpf.
--
Jiri Kosina
SUSE Labs