Return-Path: Date: Sun, 19 Oct 2008 21:40:02 +0200 (CEST) From: Jiri Kosina To: Jiri Slaby cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Noonan , Justin Mattock , Sven Anders , Marcel Holtmann , linux-bluetooth@vger.kernel.org Subject: Re: several messages In-Reply-To: <1224425749-22652-2-git-send-email-jirislaby@gmail.com> Message-ID: References: <1224425749-22652-1-git-send-email-jirislaby@gmail.com> <1224425749-22652-2-git-send-email-jirislaby@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-ID: On Sun, 19 Oct 2008, Jiri Slaby wrote: > +enum hid_type { > + HID_TYPE_UNKNOWN = 0, > + HID_TYPE_MOUSE, > + HID_TYPE_KEYBOARD > +}; > + Do we really need the HID_TYPE_KEYBOARD at all? It's not used anywhere in the code. I'd propose to add it when it is actually needed. I.e. have the enum contain something like HID_TYPE_MOUSE HID_TYPE_OTHER for now, and add whatever will become necessary in the future, what do you think? On Sun, 19 Oct 2008, Jiri Slaby wrote: > +/** > + * hid_mouse_ignore_list - mouse devices which must not be held by the hid layer > + */ I think a more descriptive comment would be appropriate here. It might not be obvious on the first sight why this needs to be done separately from the generic hid_blacklist. I.e. something like /** * There are composite devices for which we want to ignore only a certain * interface. This is a list of devices for which only the mouse interface * will be ignored. */ maybe? Thanks, -- Jiri Kosina SUSE Labs