Return-Path: MIME-Version: 1.0 In-Reply-To: <1240310500.5260.16.camel@localhost.localdomain> References: <8b5debfa0904200819sbcb6b08q5f33782381dcb229@mail.gmail.com> <1240241475.5260.4.camel@localhost.localdomain> <8b5debfa0904200852o7ba92880u15e950bf655eb81d@mail.gmail.com> <1240244938.5260.5.camel@localhost.localdomain> <8b5debfa0904201218s3695bc01l39842aad26afcc4e@mail.gmail.com> <1240310500.5260.16.camel@localhost.localdomain> Date: Tue, 21 Apr 2009 17:11:10 +0530 Message-ID: <8b5debfa0904210441k68fdb06bv2612f690a8cd8116@mail.gmail.com> Subject: Re: [PATCH] Adding priority check for plugins. From: alok barsode To: Marcel Holtmann Cc: linux-bluetooth Content-Type: multipart/mixed; boundary=0016364274d593c7d604680f1f65 List-ID: --0016364274d593c7d604680f1f65 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Marcel, Modified patch attached. On Tue, Apr 21, 2009 at 4:11 PM, Marcel Holtmann wrote: > Hi Alok, > >> >> modified patch attached. >> > >> > please to the line-break with BLUETOOTH_PLUGIN_DEFINE a little bit more >> > like what ConnMan does so it looks nicer. >> > >> Infact i copied the syntax for BLUETOOTH_PLUGIN_DEFINE from the one in >> connman. :D > > I meant the calls inside the plugins and not the definition itself. > > Regards > > Marcel > > > --0016364274d593c7d604680f1f65 Content-Type: text/x-diff; charset=US-ASCII; name="0001-Add-priority-field-to-plugin-descriptor-definition-a.patch" Content-Disposition: attachment; filename="0001-Add-priority-field-to-plugin-descriptor-definition-a.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ftsiytnh0 RnJvbSBhOGM0N2RkNWRmMTZhMGFhMWViNzZlZGVhMzI1NGE1NzExYzgzMzI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbG9rIEJhcnNvZGUgPGFsb2suYmFyc29kZUBhemluZ28uY29t PgpEYXRlOiBUdWUsIDIxIEFwciAyMDA5IDE2OjMzOjM2ICswNTMwClN1YmplY3Q6IFtQQVRDSF0g QWRkIHByaW9yaXR5IGZpZWxkIHRvIHBsdWdpbiBkZXNjcmlwdG9yIGRlZmluaXRpb24gYW5kCiBs b2FkIHBsdWdpbnMgaW4gcHJpb3JpdHkgb3JkZXIuCgotLS0KIGF1ZGlvL21haW4uYyAgICAgIHwg ICAgMyArKy0KIGlucHV0L21haW4uYyAgICAgIHwgICAgMyArKy0KIG5ldHdvcmsvbWFpbi5jICAg IHwgICAgMyArKy0KIHBsdWdpbnMvZWNoby5jICAgIHwgICAgMyArKy0KIHBsdWdpbnMvaGFsLmMg ICAgIHwgICAgMyArKy0KIHBsdWdpbnMvbmV0bGluay5jIHwgICAgMyArKy0KIHBsdWdpbnMvc2Vy dmljZS5jIHwgICAgMyArKy0KIHBsdWdpbnMvc3RvcmFnZS5jIHwgICAgMyArKy0KIHNlcmlhbC9t YWluLmMgICAgIHwgICAgMyArKy0KIHNyYy9wbHVnaW4uYyAgICAgIHwgICAyOSArKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLQogc3JjL3BsdWdpbi5oICAgICAgfCAgICA4ICsrKysrKy0tCiAx MSBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9hdWRpby9tYWluLmMgYi9hdWRpby9tYWluLmMKaW5kZXggNTY1YzgzYi4uNzYxMzky YSAxMDA2NDQKLS0tIGEvYXVkaW8vbWFpbi5jCisrKyBiL2F1ZGlvL21haW4uYwpAQCAtMTc2LDQg KzE3Niw1IEBAIHN0YXRpYyB2b2lkIGF1ZGlvX2V4aXQodm9pZCkKIAlkYnVzX2Nvbm5lY3Rpb25f dW5yZWYoY29ubmVjdGlvbik7CiB9CiAKLUJMVUVUT09USF9QTFVHSU5fREVGSU5FKCJhdWRpbyIs IFZFUlNJT04sIGF1ZGlvX2luaXQsIGF1ZGlvX2V4aXQpCitCTFVFVE9PVEhfUExVR0lOX0RFRklO RSgiYXVkaW8iLCBWRVJTSU9OLAorCQkJQkxVRVRPT1RIX1BMVUdJTl9QUklPUklUWV9ERUZBVUxU LCBhdWRpb19pbml0LCBhdWRpb19leGl0KQpkaWZmIC0tZ2l0IGEvaW5wdXQvbWFpbi5jIGIvaW5w dXQvbWFpbi5jCmluZGV4IDAxMGI3MzEuLjI4MzQyMDEgMTAwNjQ0Ci0tLSBhL2lucHV0L21haW4u YworKysgYi9pbnB1dC9tYWluLmMKQEAgLTgyLDQgKzgyLDUgQEAgc3RhdGljIHZvaWQgaW5wdXRf ZXhpdCh2b2lkKQogCWRidXNfY29ubmVjdGlvbl91bnJlZihjb25uZWN0aW9uKTsKIH0KIAotQkxV RVRPT1RIX1BMVUdJTl9ERUZJTkUoImlucHV0IiwgVkVSU0lPTiwgaW5wdXRfaW5pdCwgaW5wdXRf ZXhpdCkKK0JMVUVUT09USF9QTFVHSU5fREVGSU5FKCJpbnB1dCIsIFZFUlNJT04sCisJCQlCTFVF VE9PVEhfUExVR0lOX1BSSU9SSVRZX0RFRkFVTFQsIGlucHV0X2luaXQsIGlucHV0X2V4aXQpCmRp ZmYgLS1naXQgYS9uZXR3b3JrL21haW4uYyBiL25ldHdvcmsvbWFpbi5jCmluZGV4IDVmOTZkNGIu LjdlNDVlYmEgMTAwNjQ0Ci0tLSBhL25ldHdvcmsvbWFpbi5jCisrKyBiL25ldHdvcmsvbWFpbi5j CkBAIC01NSw0ICs1NSw1IEBAIHN0YXRpYyB2b2lkIG5ldHdvcmtfZXhpdCh2b2lkKQogCWRidXNf Y29ubmVjdGlvbl91bnJlZihjb25uZWN0aW9uKTsKIH0KIAotQkxVRVRPT1RIX1BMVUdJTl9ERUZJ TkUoIm5ldHdvcmsiLCBWRVJTSU9OLCBuZXR3b3JrX2luaXQsIG5ldHdvcmtfZXhpdCkKK0JMVUVU T09USF9QTFVHSU5fREVGSU5FKCJuZXR3b3JrIiwgVkVSU0lPTiwKKwkJCUJMVUVUT09USF9QTFVH SU5fUFJJT1JJVFlfREVGQVVMVCwgbmV0d29ya19pbml0LCBuZXR3b3JrX2V4aXQpCmRpZmYgLS1n aXQgYS9wbHVnaW5zL2VjaG8uYyBiL3BsdWdpbnMvZWNoby5jCmluZGV4IDgzMmJmOGIuLjQ0NDNm ZjEgMTAwNjQ0Ci0tLSBhL3BsdWdpbnMvZWNoby5jCisrKyBiL3BsdWdpbnMvZWNoby5jCkBAIC0x NjMsNCArMTYzLDUgQEAgc3RhdGljIHZvaWQgZWNob19leGl0KHZvaWQpCiAJYnRkX3VucmVnaXN0 ZXJfYWRhcHRlcl9kcml2ZXIoJmVjaG9fc2VydmVyKTsKIH0KIAotQkxVRVRPT1RIX1BMVUdJTl9E RUZJTkUoImVjaG8iLCBWRVJTSU9OLCBlY2hvX2luaXQsIGVjaG9fZXhpdCkKK0JMVUVUT09USF9Q TFVHSU5fREVGSU5FKCJlY2hvIiwgVkVSU0lPTiwKKwkJCUJMVUVUT09USF9QTFVHSU5fUFJJT1JJ VFlfREVGQVVMVCwgZWNob19pbml0LCBlY2hvX2V4aXQpCmRpZmYgLS1naXQgYS9wbHVnaW5zL2hh bC5jIGIvcGx1Z2lucy9oYWwuYwppbmRleCAyMTliNDZlLi42ODM3NzdjIDEwMDY0NAotLS0gYS9w bHVnaW5zL2hhbC5jCisrKyBiL3BsdWdpbnMvaGFsLmMKQEAgLTE1OCw0ICsxNTgsNSBAQCBzdGF0 aWMgdm9pZCBoYWxfZXhpdCh2b2lkKQogCWJ0ZF91bnJlZ2lzdGVyX2FkYXB0ZXJfZHJpdmVyKCZo YWxfZHJpdmVyKTsKIH0KIAotQkxVRVRPT1RIX1BMVUdJTl9ERUZJTkUoImhhbCIsIFZFUlNJT04s IGhhbF9pbml0LCBoYWxfZXhpdCkKK0JMVUVUT09USF9QTFVHSU5fREVGSU5FKCJoYWwiLCBWRVJT SU9OLAorCQkJQkxVRVRPT1RIX1BMVUdJTl9QUklPUklUWV9ERUZBVUxULCBoYWxfaW5pdCwgaGFs X2V4aXQpCmRpZmYgLS1naXQgYS9wbHVnaW5zL25ldGxpbmsuYyBiL3BsdWdpbnMvbmV0bGluay5j CmluZGV4IGY3NzdjZjkuLmQxZTkxYjIgMTAwNjQ0Ci0tLSBhL3BsdWdpbnMvbmV0bGluay5jCisr KyBiL3BsdWdpbnMvbmV0bGluay5jCkBAIC0xMjMsNCArMTIzLDUgQEAgc3RhdGljIHZvaWQgbmV0 bGlua19leGl0KHZvaWQpCiAJbmxfaGFuZGxlX2Rlc3Ryb3koaGFuZGxlKTsKIH0KIAotQkxVRVRP T1RIX1BMVUdJTl9ERUZJTkUoIm5ldGxpbmsiLCBWRVJTSU9OLCBuZXRsaW5rX2luaXQsIG5ldGxp bmtfZXhpdCkKK0JMVUVUT09USF9QTFVHSU5fREVGSU5FKCJuZXRsaW5rIiwgVkVSU0lPTiwKKwkJ CUJMVUVUT09USF9QTFVHSU5fUFJJT1JJVFlfREVGQVVMVCwgbmV0bGlua19pbml0LCBuZXRsaW5r X2V4aXQpCmRpZmYgLS1naXQgYS9wbHVnaW5zL3NlcnZpY2UuYyBiL3BsdWdpbnMvc2VydmljZS5j CmluZGV4IGIyOGM5YzEuLmQ4MWFiZTggMTAwNjQ0Ci0tLSBhL3BsdWdpbnMvc2VydmljZS5jCisr KyBiL3BsdWdpbnMvc2VydmljZS5jCkBAIC04NTksNCArODU5LDUgQEAgc3RhdGljIHZvaWQgc2Vy dmljZV9leGl0KHZvaWQpCiAJZGJ1c19jb25uZWN0aW9uX3VucmVmKGNvbm5lY3Rpb24pOwogfQog Ci1CTFVFVE9PVEhfUExVR0lOX0RFRklORSgic2VydmljZSIsIFZFUlNJT04sIHNlcnZpY2VfaW5p dCwgc2VydmljZV9leGl0KQorQkxVRVRPT1RIX1BMVUdJTl9ERUZJTkUoInNlcnZpY2UiLCBWRVJT SU9OLAorCQkJQkxVRVRPT1RIX1BMVUdJTl9QUklPUklUWV9ERUZBVUxULCBzZXJ2aWNlX2luaXQs IHNlcnZpY2VfZXhpdCkKZGlmZiAtLWdpdCBhL3BsdWdpbnMvc3RvcmFnZS5jIGIvcGx1Z2lucy9z dG9yYWdlLmMKaW5kZXggYzRkYmUxNi4uMGFiYzYxNiAxMDA2NDQKLS0tIGEvcGx1Z2lucy9zdG9y YWdlLmMKKysrIGIvcGx1Z2lucy9zdG9yYWdlLmMKQEAgLTM5LDQgKzM5LDUgQEAgc3RhdGljIHZv aWQgc3RvcmFnZV9leGl0KHZvaWQpCiB7CiB9CiAKLUJMVUVUT09USF9QTFVHSU5fREVGSU5FKCJz dG9yYWdlIiwgVkVSU0lPTiwgc3RvcmFnZV9pbml0LCBzdG9yYWdlX2V4aXQpCitCTFVFVE9PVEhf UExVR0lOX0RFRklORSgic3RvcmFnZSIsIFZFUlNJT04sCisJCQlCTFVFVE9PVEhfUExVR0lOX1BS SU9SSVRZX0RFRkFVTFQsIHN0b3JhZ2VfaW5pdCwgc3RvcmFnZV9leGl0KQpkaWZmIC0tZ2l0IGEv c2VyaWFsL21haW4uYyBiL3NlcmlhbC9tYWluLmMKaW5kZXggNWRiMzg5Yy4uMzk0OTI3MSAxMDA2 NDQKLS0tIGEvc2VyaWFsL21haW4uYworKysgYi9zZXJpYWwvbWFpbi5jCkBAIC01NSw0ICs1NSw1 IEBAIHN0YXRpYyB2b2lkIHNlcmlhbF9leGl0KHZvaWQpCiAJZGJ1c19jb25uZWN0aW9uX3VucmVm KGNvbm5lY3Rpb24pOwogfQogCi1CTFVFVE9PVEhfUExVR0lOX0RFRklORSgic2VyaWFsIiwgVkVS U0lPTiwgc2VyaWFsX2luaXQsIHNlcmlhbF9leGl0KQorQkxVRVRPT1RIX1BMVUdJTl9ERUZJTkUo InNlcmlhbCIsIFZFUlNJT04sCisJCQlCTFVFVE9PVEhfUExVR0lOX1BSSU9SSVRZX0RFRkFVTFQs IHNlcmlhbF9pbml0LCBzZXJpYWxfZXhpdCkKZGlmZiAtLWdpdCBhL3NyYy9wbHVnaW4uYyBiL3Ny Yy9wbHVnaW4uYwppbmRleCAwNTFjMzNjLi5hMTdhN2VhIDEwMDY0NAotLS0gYS9zcmMvcGx1Z2lu LmMKKysrIGIvc3JjL3BsdWdpbi5jCkBAIC00Myw5ICs0MywxOCBAQCBzdGF0aWMgR1NMaXN0ICpw bHVnaW5zID0gTlVMTDsKIAogc3RydWN0IGJsdWV0b290aF9wbHVnaW4gewogCXZvaWQgKmhhbmRs ZTsKKwlnYm9vbGVhbiBhY3RpdmU7CiAJc3RydWN0IGJsdWV0b290aF9wbHVnaW5fZGVzYyAqZGVz YzsKIH07CiAKK3N0YXRpYyBnaW50IGNvbXBhcmVfcHJpb3JpdHkoZ2NvbnN0cG9pbnRlciBhLCBn Y29uc3Rwb2ludGVyIGIpCit7CisJY29uc3Qgc3RydWN0IGJsdWV0b290aF9wbHVnaW4gKnBsdWdp bjEgPSBhOworCWNvbnN0IHN0cnVjdCBibHVldG9vdGhfcGx1Z2luICpwbHVnaW4yID0gYjsKKwor CXJldHVybiBwbHVnaW4yLT5kZXNjLT5wcmlvcml0eSAtIHBsdWdpbjEtPmRlc2MtPnByaW9yaXR5 OworfQorCiBzdGF0aWMgZ2Jvb2xlYW4gYWRkX3BsdWdpbih2b2lkICpoYW5kbGUsIHN0cnVjdCBi bHVldG9vdGhfcGx1Z2luX2Rlc2MgKmRlc2MpCiB7CiAJc3RydWN0IGJsdWV0b290aF9wbHVnaW4g KnBsdWdpbjsKQEAgLTYzLDE0ICs3MiwxMCBAQCBzdGF0aWMgZ2Jvb2xlYW4gYWRkX3BsdWdpbih2 b2lkICpoYW5kbGUsIHN0cnVjdCBibHVldG9vdGhfcGx1Z2luX2Rlc2MgKmRlc2MpCiAJCXJldHVy biBGQUxTRTsKIAogCXBsdWdpbi0+aGFuZGxlID0gaGFuZGxlOworCXBsdWdpbi0+YWN0aXZlID0g RkFMU0U7CiAJcGx1Z2luLT5kZXNjID0gZGVzYzsKIAotCWlmIChkZXNjLT5pbml0KCkgPCAwKSB7 Ci0JCWdfZnJlZShwbHVnaW4pOwotCQlyZXR1cm4gRkFMU0U7Ci0JfQotCi0JcGx1Z2lucyA9IGdf c2xpc3RfYXBwZW5kKHBsdWdpbnMsIHBsdWdpbik7CisJcGx1Z2lucyA9IGdfc2xpc3RfaW5zZXJ0 X3NvcnRlZChwbHVnaW5zLCBwbHVnaW4sIGNvbXBhcmVfcHJpb3JpdHkpOwogCiAJcmV0dXJuIFRS VUU7CiB9CkBAIC05OCw2ICsxMDMsNyBAQCBzdGF0aWMgZ2Jvb2xlYW4gaXNfZGlzYWJsZWQoY29u c3QgY2hhciAqbmFtZSwgY2hhciAqKmxpc3QpCiAKIGdib29sZWFuIHBsdWdpbl9pbml0KEdLZXlG aWxlICpjb25maWcpCiB7CisJR1NMaXN0ICpsaXN0OwogCUdEaXIgKmRpcjsKIAljb25zdCBnY2hh ciAqZmlsZTsKIAlnY2hhciAqKmRpc2FibGVkOwpAQCAtMTcxLDYgKzE3NywxNSBAQCBnYm9vbGVh biBwbHVnaW5faW5pdChHS2V5RmlsZSAqY29uZmlnKQogCiAJZ19zdHJmcmVldihkaXNhYmxlZCk7 CiAKKwlmb3IgKGxpc3QgPSBwbHVnaW5zOyBsaXN0OyBsaXN0ID0gbGlzdC0+bmV4dCkgeworCQlz dHJ1Y3QgYmx1ZXRvb3RoX3BsdWdpbiAqcGx1Z2luID0gbGlzdC0+ZGF0YTsKKworCQlpZiAocGx1 Z2luLT5kZXNjLT5pbml0KCkgPCAwKQorCQkJY29udGludWU7CisKKwkJcGx1Z2luLT5hY3RpdmUg PSBUUlVFOworCX0KKwogCXJldHVybiBUUlVFOwogfQogCkBAIC0xODMsNyArMTk4LDcgQEAgdm9p ZCBwbHVnaW5fY2xlYW51cCh2b2lkKQogCWZvciAobGlzdCA9IHBsdWdpbnM7IGxpc3Q7IGxpc3Qg PSBsaXN0LT5uZXh0KSB7CiAJCXN0cnVjdCBibHVldG9vdGhfcGx1Z2luICpwbHVnaW4gPSBsaXN0 LT5kYXRhOwogCi0JCWlmIChwbHVnaW4tPmRlc2MtPmV4aXQpCisJCWlmIChwbHVnaW4tPmFjdGl2 ZSA9PSBUUlVFICYmIHBsdWdpbi0+ZGVzYy0+ZXhpdCkKIAkJCXBsdWdpbi0+ZGVzYy0+ZXhpdCgp OwogCiAJCWRsY2xvc2UocGx1Z2luLT5oYW5kbGUpOwpkaWZmIC0tZ2l0IGEvc3JjL3BsdWdpbi5o IGIvc3JjL3BsdWdpbi5oCmluZGV4IDYyZDVmNzUuLmRjMzcyMjQgMTAwNjQ0Ci0tLSBhL3NyYy9w bHVnaW4uaAorKysgYi9zcmMvcGx1Z2luLmgKQEAgLTIwLDE3ICsyMCwyMSBAQAogICogIEZvdW5k YXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0LCBGaWZ0aCBGbG9vciwgQm9zdG9uLCBNQSAgMDIx MTAtMTMwMSAgVVNBCiAgKgogICovCisjZGVmaW5lIEJMVUVUT09USF9QTFVHSU5fUFJJT1JJVFlf TE9XICAgICAgLTEwMAorI2RlZmluZSBCTFVFVE9PVEhfUExVR0lOX1BSSU9SSVRZX0RFRkFVTFQg ICAgIDAKKyNkZWZpbmUgQkxVRVRPT1RIX1BMVUdJTl9QUklPUklUWV9ISUdIICAgICAgMTAwCiAK IHN0cnVjdCBibHVldG9vdGhfcGx1Z2luX2Rlc2MgewogCWNvbnN0IGNoYXIgKm5hbWU7CiAJY29u c3QgY2hhciAqdmVyc2lvbjsKKwlpbnQgcHJpb3JpdHk7CiAJaW50ICgqaW5pdCkgKHZvaWQpOwog CXZvaWQgKCpleGl0KSAodm9pZCk7CiB9OwogCi0jZGVmaW5lIEJMVUVUT09USF9QTFVHSU5fREVG SU5FKG5hbWUsdmVyc2lvbixpbml0LGV4aXQpIFwKKyNkZWZpbmUgQkxVRVRPT1RIX1BMVUdJTl9E RUZJTkUobmFtZSwgdmVyc2lvbiwgcHJpb3JpdHksIGluaXQsIGV4aXQpIFwKIAkJZXh0ZXJuIHN0 cnVjdCBibHVldG9vdGhfcGx1Z2luX2Rlc2MgYmx1ZXRvb3RoX3BsdWdpbl9kZXNjIFwKIAkJCQlf X2F0dHJpYnV0ZV9fICgodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSk7IFwKIAkJc3RydWN0IGJsdWV0 b290aF9wbHVnaW5fZGVzYyBibHVldG9vdGhfcGx1Z2luX2Rlc2MgPSB7IFwKLQkJCW5hbWUsIHZl cnNpb24sIGluaXQsIGV4aXQgXAorCQkJbmFtZSwgdmVyc2lvbiwgcHJpb3JpdHksIGluaXQsIGV4 aXQgXAogCQl9OwotLSAKMS41LjYuMwoK --0016364274d593c7d604680f1f65--