Return-Path: Date: Fri, 29 Jan 2010 14:53:02 +0100 (CET) From: Jiri Kosina To: Bastien Nocera Cc: "Gunn, Brian" , Marcel Holtmann , Dmitry Torokhov , linux-input , BlueZ development , Ping Subject: RE: [PATCHes] Implement Bluetooth Wacom tablet's mode change in the kernel In-Reply-To: <1264772713.29532.4943.camel@localhost.localdomain> Message-ID: References: <1263833399.20565.2905.camel@localhost.localdomain> <1263886149.5591.166.camel@localhost.localdomain> <1263897015.20565.3988.camel@localhost.localdomain> <1264037759.1735.5008.camel@localhost.localdomain> <1264719198.29532.3149.camel@localhost.localdomain> <1264772713.29532.4943.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-ID: On Fri, 29 Jan 2010, Bastien Nocera wrote: > > Having separate methods for feature and output reports should be > > sufficient and general enough, right? > > Most likely, yes. Feature is enough for the 2 devices I provided patches > for. Could you please comment on what you'd like the implementation of > this to look like? I think that we should probably introduce flag parameter into hid_output_raw_report(), which would indicate whether OUTPUT or FEATURE report should be sent. This makes sense both for Bluetooth and HID. I will send out patches later today for you guys to test (and for Marcel to Ack the Bluetooth part). > This simple bug fix is turning into a lot more to-and-fro than I would > have anticipated. It's nice example of evolution, isn't it? :) Thanks, -- Jiri Kosina SUSE Labs, Novell Inc.