Return-Path: From: "Gunn, Brian" To: Bastien Nocera , Marcel Holtmann CC: Dmitry Torokhov , linux-input , BlueZ development , Ping , Jiri Kosina Date: Tue, 19 Jan 2010 08:36:58 -0800 Subject: RE: [PATCHes] Implement Bluetooth Wacom tablet's mode change in the kernel Message-ID: References: <1263833399.20565.2905.camel@localhost.localdomain> <1263886149.5591.166.camel@localhost.localdomain>,<1263897015.20565.3988.camel@localhost.localdomain> In-Reply-To: <1263897015.20565.3988.camel@localhost.localdomain> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: I tested this with a Bluetooth remote control. As I understand, reports ca= n be written to either the interrupt or control sockets. I'm happy to test= other changes to let this be selectable. Brian ________________________________________ From: Bastien Nocera [hadess@hadess.net] Sent: Tuesday, January 19, 2010 2:30 AM To: Marcel Holtmann Cc: Dmitry Torokhov; linux-input; BlueZ development; Gunn, Brian; Ping; Jir= i Kosina Subject: Re: [PATCHes] Implement Bluetooth Wacom tablet's mode change in th= e kernel On Mon, 2010-01-18 at 23:29 -0800, Marcel Holtmann wrote: > Hi Bastien, > > > Here's a patch to do the Bluetooth Wacom tablet's mode setting in the > > kernel. In the past, it was done in a patch in bluetootd. > > > > The first patch is probably completely wrong. Right now, > > hid_output_raw_report is done on the intr socket, instead of the ctrl > > socket. If it's correct to do it on the intr socket, we'd need to add > > some API as a way to select the ctrl socket instead for use in that > > driver. > > actually the interrupt should be incoming only. So moving the raw output > to the control channel seems fine to. Any reason why it is on the > interrupt channel in the first place? The patch was written by Jiri and tested by Brian. Not sure what sort of device Brian tested this with...