Return-Path: MIME-Version: 1.0 In-Reply-To: <35c90d961002251705j2cd95a8cjc7d10aa432a49f4@mail.gmail.com> References: <1265918068-14721-1-git-send-email-npelly@google.com> <35c90d961002151315i5fc0f5b9y36aaba4415987a2f@mail.gmail.com> <4B7BB746.1040806@nokia.com> <35c90d961002170849m1d13743fg725a87594d63b80c@mail.gmail.com> <1266427894.8849.66.camel@localhost.localdomain> <35c90d961002181547x1ea26ba7je4eee29ef29e6fd2@mail.gmail.com> <4B7E46FC.5030408@nokia.com> <35c90d961002191323x50203ca1x8ed709b3f128e41d@mail.gmail.com> <4B82380A.6040204@nokia.com> <35c90d961002251705j2cd95a8cjc7d10aa432a49f4@mail.gmail.com> Date: Fri, 19 Mar 2010 14:48:17 -0400 Message-ID: <9c9ad6a31003191148v450da1cdg1c2c6e1ad2a04d3b@mail.gmail.com> Subject: Re: [PATCH] Bluetooth: Allow SCO/eSCO packet type selection for outgoing SCO connections. From: smcoe1 To: Marcel Holtmann Cc: Ville Tervo , Nick Pelly , "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 List-ID: Hi Marcel, On Thu, Feb 25, 2010 at 9:05 PM, Nick Pelly wrote: > On Sun, Feb 21, 2010 at 11:53 PM, Ville Tervo wrote: >> Nick Pelly wrote: >>>>> >>>>> Attached is a new patch with the consistent bit logic. >>>>> >>>>> Comments? >>>> >>>> In order to keep backwards compatibility 1 should mean "don't allow this >>>> packet type" for all packets. Other wise old application with new kernel >>>> would not allow any packet types. >>> >>> The current patch achieves this backwards compatibility by assuming >>> that all packet types are allowed if the old sockaddr_sco struct is >>> used (it checks the size), or if sco_pkt_type is 0. >> >> OK. Then my concerns are gone. > > As best I can tell there are no objections. We're going ahead with this patch. > > http://android.git.kernel.org/?p=kernel/common.git;a=commit;h=3b077241e02041b1f03fee912896b8de1d7ac096 > > Nick Is this patch (or something similar) being considered for merging into the bluetooth-2.6 tree. We are experiencing similar issues with these and other car kits. Thanks, Steve