Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <1273486527-7855-13-git-send-email-sancane@gmail.com>
References: <1273486527-7855-1-git-send-email-sancane@gmail.com>
	 <1273486527-7855-5-git-send-email-sancane@gmail.com>
	 <1273486527-7855-6-git-send-email-sancane@gmail.com>
	 <1273486527-7855-7-git-send-email-sancane@gmail.com>
	 <1273486527-7855-8-git-send-email-sancane@gmail.com>
	 <1273486527-7855-9-git-send-email-sancane@gmail.com>
	 <1273486527-7855-10-git-send-email-sancane@gmail.com>
	 <1273486527-7855-11-git-send-email-sancane@gmail.com>
	 <1273486527-7855-12-git-send-email-sancane@gmail.com>
	 <1273486527-7855-13-git-send-email-sancane@gmail.com>
Date: Wed, 12 May 2010 12:00:56 -0300
Message-ID: <AANLkTinsaue1kDRc3Q0fywYeRJ11yeTjS6GXo2nO9vzD@mail.gmail.com>
Subject: Re: [PATCH 13/25] Process standard op. codes in pending and active
	state
From: Raul Herbster <raul.herbster@signove.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Santiago,

2010/5/10 Santiago Carot-Nemesio <sancane@gmail.com>:
> From: Santiago Carot Nemesio <sancane@gmail.com>
>
> ---
> ?mcap/mcap.c | ? 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> ?1 files changed, 61 insertions(+), 2 deletions(-)
>
> diff --git a/mcap/mcap.c b/mcap/mcap.c
> index 7aeefb2..6d548b9 100644
> --- a/mcap/mcap.c
> +++ b/mcap/mcap.c
> @@ -635,6 +635,50 @@ static void process_md_reconnect_mdl_req(struct mcap_mcl *mcl, uint8_t *cmd,
> ? ? ? ?send4B_cmd(mcl, MCAP_MD_RECONNECT_MDL_RSP, MCAP_SUCCESS, mdl_id);
> ?}
>
> +static void process_md_abort_mdl_req(struct mcap_mcl *mcl, uint8_t *cmd,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? uint32_t len)
> +{
> + ? ? ? mcap_md_req *req;
> + ? ? ? GSList *l;
> + ? ? ? struct mcap_mdl *mdl, *del;
> + ? ? ? uint16_t mdl_id;
> +
> + ? ? ? if (len != sizeof(mcap_md_req)) {
> + ? ? ? ? ? ? ? send4B_cmd(mcl, MCAP_MD_ABORT_MDL_RSP,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? MCAP_INVALID_PARAM_VALUE, MCAP_MDLID_RESERVED);
> + ? ? ? ? ? ? ? return;
> + ? ? ? }
> +
> + ? ? ? req = (mcap_md_req *)cmd;
> + ? ? ? mdl_id = ntohs(req->mdl);
> + ? ? ? mcl->state = MCL_CONNECTED;
> + ? ? ? for (l = mcl->mdls; l; l = l->next) {
> + ? ? ? ? ? ? ? mdl = l->data;
> + ? ? ? ? ? ? ? if ((mdl_id == mdl->mdlid) && (mdl->state == MDL_WAITING)) {
> + ? ? ? ? ? ? ? ? ? ? ? del = mdl;
> + ? ? ? ? ? ? ? ? ? ? ? if (mcl->state != MCL_CONNECTED)
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? break;
> + ? ? ? ? ? ? ? ? ? ? ? continue;
> + ? ? ? ? ? ? ? }
> + ? ? ? ? ? ? ? if ((mdl->state == MDL_CONNECTED) && (mcl->state != MCL_ACTIVE))
> + ? ? ? ? ? ? ? ? ? ? ? mcl->state = MCL_ACTIVE;
> +
> + ? ? ? ? ? ? ? if ((del) && (mcl->state == MCL_ACTIVE))
> + ? ? ? ? ? ? ? ? ? ? ? break;
> + ? ? ? }
> +
> + ? ? ? if (!del) {
> + ? ? ? ? ? ? ? send4B_cmd(mcl, MCAP_MD_ABORT_MDL_RSP, MCAP_INVALID_MDL, mdl_id);

More than 80 characters in line.

[]?s
--Raul