Return-Path: Message-ID: <4C05D9D8.2030606@Atheros.com> Date: Wed, 2 Jun 2010 09:41:04 +0530 From: Suraj Sumangala MIME-Version: 1.0 To: Marcel Holtmann CC: Luis Rodriguez , Suraj Sumangala , "linux-bluetooth@vger.kernel.org" , Jothikumar Mothilal Subject: Re: [PATCH 2/3] Replace hci_recv_fragment calls References: <1275379440.19477.9.camel@atheros013-desktop> <1275379734.19477.14.camel@atheros013-desktop> <1275422353.2182.5.camel@localhost.localdomain> <20100601205120.GB6037@tux> <1275429550.2182.7.camel@localhost.localdomain> In-Reply-To: <1275429550.2182.7.camel@localhost.localdomain> Content-Type: text/plain; charset="UTF-8"; format=flowed List-ID: Hi Marcel, On 6/2/2010 3:29 AM, Marcel Holtmann wrote: > Hi Luis, > >>>> You want to unify patches 1 and 2. Patches upstream should be atomic so that if you apply it, it should make everything still work. Your first patch removes hci_recv_fragment() and then this one fixes the places that call it, you want to do both in one shot. >>> >>> actually I prefer to leave these two patches out for now. Since the >>> renaming could be done easily later. The important part is actually the >>> other implementation. >> >> Won't that break compilation on the first patch since all existing >> code users no longer have the exported symbol available? > > no. The important change here is for the H4 specific stream fragment > handling. The rest is just a renaming. So 3/3 is the important patch and > 1/2 and 2/2 are just cosmetic changes. > > Regards > > Marcel > > I will send 3/3 as a separate patch for you to verify. Regards Suraj