Return-Path: Date: Fri, 23 Jul 2010 11:27:54 +0300 From: Johan Hedberg To: Inga Stotland , linux-bluetooth@vger.kernel.org, rshaffer@codeaurora.org, marcel@holtmann.org Subject: Re: [PATCH v4 0/5] Enhanced support for extended inquiry response Message-ID: <20100723082754.GA12563@jh-x301> References: <1279814780-29673-1-git-send-email-ingas@codeaurora.org> <20100723082045.GA1600@jh-x301> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100723082045.GA1600@jh-x301> List-ID: On Fri, Jul 23, 2010, Johan Hedberg wrote: > Could you explain to me why this is needed. With the current git > (without your patches) the local EIR data seems to be correctly updated > whenever the SDP database changes. Are there some scenarios when this > doesn't happen? I did a quick test with sdptool add/del while bluetoothd > was running and I could see the appropriate "Write Extended Inquiry > Response" commands with hcidump. It seems currently this only happens when a local record change causes the service class bits of the class of device to be updated too. If the record change doesn't affect the class of device then it seems the EIR data isn't modified accordingly. Is this correct? If so, could you please add that information to your commit message so that it's clear why the patch is needed. Johan