Return-Path: References: <1278625779.10421.80.camel@localhost.localdomain> <1278968772-29446-1-git-send-email-rshaffer@codeaurora.org> <1278972477.6282.10.camel@localhost.localdomain> <1279135803.6282.58.camel@localhost.localdomain> Message-Id: <242ECFC3-02DC-413B-BD49-A2B2650202B3@codeaurora.org> From: Matthew Wilson To: Marcel Holtmann In-Reply-To: <1279135803.6282.58.camel@localhost.localdomain> Content-Type: multipart/alternative; boundary=Apple-Mail-18-186022871 Mime-Version: 1.0 (iPad Mail 7B367) Subject: Re: [PATCH 3/3] Bluetooth: Synchronize SCO/eSCO connection requests to ACL state Date: Wed, 14 Jul 2010 15:55:33 -0500 Cc: "Perelet, Oleg" , Ron Shaffer , "linux-bluetooth@vger.kernel.org" , "Wilson, Matt" List-ID: --Apple-Mail-18-186022871 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Marcel, On Jul 14, 2010, at 2:30 PM, Marcel Holtmann = wrote: >>=20 >>=20 >>=20 >=20 > is there really a problem? The LMP will send an error via HCI. So we = do > get the mode changed event, but just with an error. And since we are = not > checking the error at all, we just go ahead with the SCO setup attempt > in that case. The attempt to start SCO after the related ACL is no longer present = makes no sense. Either after mode change event with no success or disconnection complete = event the result is the same; there is no valid ACL to attempt SCO/eSCO. Error code 0x02 "unknown connection identifier" may apply for the = command status event for setup synchronous connection command but the = spec does not require it. -Matt= --Apple-Mail-18-186022871 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Jul = 14, 2010, at 2:30 PM, Marcel Holtmann <marcel@holtmann.org> = wrote:

is there = really a problem? The LMP will send an error via HCI. So we = do
get the mode changed event, but just with an error. = And since we are not
checking the error at all, we just = go ahead with the SCO setup attempt
in that = case.

The attempt to start SCO after the related ACL is no = longer present makes no sense.

Either after = mode change event with no success or disconnection complete event the = result is the same; there is no valid ACL to attempt = SCO/eSCO.

Error code 0x02 "unknown connection = identifier" may apply for the command status event for setup synchronous = connection command but the spec does not require = it.

-Matt
= --Apple-Mail-18-186022871--