Return-Path: Message-ID: <4C375658.10904@codeaurora.org> Date: Fri, 09 Jul 2010 12:03:20 -0500 From: Ron Shaffer MIME-Version: 1.0 To: Marcel Holtmann CC: Inga Stotland , linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com Subject: Re: [PATCH 1/3] Support for adding UUID128 to extended inquiry response References: <1278540518-18620-1-git-send-email-ingas@codeaurora.org> <1278540518-18620-2-git-send-email-ingas@codeaurora.org> <1278609452.10421.31.camel@localhost.localdomain> In-Reply-To: <1278609452.10421.31.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Marcel, On 7/8/2010 12:17 PM, Marcel Holtmann wrote: > Hi Inga, > >> void register_public_browse_group(void) >> diff --git a/src/sdpd.h b/src/sdpd.h >> index e93b0b6..8fd8bbe 100644 >> --- a/src/sdpd.h >> +++ b/src/sdpd.h >> @@ -6,6 +6,7 @@ >> * Copyright (C) 2002-2003 Maxim Krasnyansky >> * Copyright (C) 2002-2010 Marcel Holtmann >> * Copyright (C) 2002-2003 Stephen Crane >> + * Copyright (C) 2010, Code Aurora Forum. All rights reserved. > > I prefer that we actually see major code contributions that justify a > copyright here before you start adding it. And so let the maintainers > worry about that later on. I don't wanna see just random copyright > additions for obvious fixes or changes that are most likely even derived > from existing code. > I'm unsure of the reasoning unless the idea is to add copyright markings to show attribution and level of contribution. In our case it's just a legal marking. If the reasoning for adding or not adding is the former, does this not rise to that level, and for my own education and future reference why not? -- Ron Shaffer Employee of the Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.