Return-Path: Date: Thu, 30 Sep 2010 10:56:18 -0300 From: "Gustavo F. Padovan" To: "Haijun.Liu" Cc: linux-bluetooth@vger.kernel.org, ville.tervo@nokia.com, dan.tian@atheros.com, suraj@atheros.com Subject: Re: [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro. Message-ID: <20100930135618.GA4615@vigoh> References: <1285836760-3234-1-git-send-email-haijun.liu@atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1285836760-3234-1-git-send-email-haijun.liu@atheros.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Haijun, * Haijun.Liu [2010-09-30 16:52:39 +0800]: > > Signed-off-by: Haijun.Liu > --- > net/bluetooth/l2cap_core.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Your patch doesn't build: net/bluetooth/l2cap_core.c: In function 'l2cap_config_req': net/bluetooth/l2cap_core.c:2988: error: 'L2CAP_CONF_FLAG_CONT' undeclared (first use in this function) net/bluetooth/l2cap_core.c:2988: error: (Each undeclared identifier is reported only once net/bluetooth/l2cap_core.c:2988: error: for each function it appears in.) net/bluetooth/l2cap_core.c: In function 'l2cap_config_rsp': net/bluetooth/l2cap_core.c:3096: error: 'L2CAP_CONF_FLAG_CONT' undeclared (first use in this function) You also have to fix your commit subject, it would be good if you can do it with 50 characters, but never overstep the 72 characters. If need to add more info the commit message is there for you ;) -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi