Return-Path: MIME-Version: 1.0 In-Reply-To: <1286814803-6740-1-git-send-email-pavan_savoy@ti.com> References: <1286814803-6740-1-git-send-email-pavan_savoy@ti.com> Date: Tue, 12 Oct 2010 00:19:10 -0400 Message-ID: Subject: Re: [PATCH] Bluetooth: TI_ST bluetooth driver From: Pavan Savoy To: linux-bluetooth@vger.kernel.org, marcel@holtmann.org Cc: greg@kroah.com, linux-kernel@vger.kernel.org, Pavan Savoy Content-Type: text/plain; charset=UTF-8 List-ID: On Mon, Oct 11, 2010 at 12:33 PM, wrote: > From: Pavan Savoy > > Gustavo, Marcel, > > I have taken care of most of the comments which you provided. > Couple of them like usage of goto's, I didn't handle since > I am not doing much error handling repeatedly there. > > I have also removed the 2 states like _REGISTERED, _RUNNING which > were not required and the flags associated with it. > I have taken care of other style comments. > > Please review and provide your comments, Marcel, I hope you find some time to provide comments. Thanks, Pavan > -- patch description -- > > This is the bluetooth protocol driver for the TI WiLink7 chipsets. > Texas Instrument's WiLink chipsets combine wireless technologies > like BT, FM, GPS and WLAN onto a single chip. > > This Bluetooth driver works on top of the TI_ST shared transport > line discipline driver which also allows other drivers like > FM V4L2 and GPS character driver to make use of the same UART interface. > > Kconfig and Makefile modifications to enable the Bluetooth > driver for Texas Instrument's WiLink 7 chipset. > > Signed-off-by: Pavan Savoy > --- > =C2=A0drivers/bluetooth/Kconfig =C2=A0 =C2=A0| =C2=A0 10 + > =C2=A0drivers/bluetooth/Makefile =C2=A0 | =C2=A0 =C2=A01 + > =C2=A0drivers/bluetooth/btwilink.c | =C2=A0455 ++++++++++++++++++++++++++= ++++++++++++++++ > =C2=A03 files changed, 466 insertions(+), 0 deletions(-) > =C2=A0create mode 100644 drivers/bluetooth/btwilink.c > > diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig > index 02deef4..e0d67dd 100644 > --- a/drivers/bluetooth/Kconfig > +++ b/drivers/bluetooth/Kconfig > @@ -219,4 +219,14 @@ config BT_ATH3K > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Say Y here to compile support for "Athe= ros firmware download driver" > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0into the kernel or say M to compile it = as module (ath3k). > > +config BT_WILINK > + =C2=A0 =C2=A0 =C2=A0 tristate "BlueZ bluetooth driver for TI ST" > + =C2=A0 =C2=A0 =C2=A0 depends on TI_ST > + =C2=A0 =C2=A0 =C2=A0 help > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 This enables the Bluetooth driver for Texas= Instrument's BT/FM/GPS > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 combo devices. This makes use of shared tra= nsport line discipline > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 core driver to communicate with the BT core= of the combo chip. > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 Say Y here to compile support for Texas Ins= trument's WiLink7 driver > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 into the kernel or say M to compile it as m= odule. > =C2=A0endmenu > diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile > index 71bdf13..5351b62 100644 > --- a/drivers/bluetooth/Makefile > +++ b/drivers/bluetooth/Makefile > @@ -28,3 +28,4 @@ hci_uart-$(CONFIG_BT_HCIUART_BCSP) =C2=A0 =C2=A0+=3D hc= i_bcsp.o > =C2=A0hci_uart-$(CONFIG_BT_HCIUART_LL) =C2=A0 =C2=A0 =C2=A0 +=3D hci_ll.o > =C2=A0hci_uart-$(CONFIG_BT_HCIUART_ATH3K) =C2=A0 =C2=A0+=3D hci_ath.o > =C2=A0hci_uart-objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:=3D $(hci_uart-y) > +obj-$(CONFIG_BT_WILINK) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:=3D btwilink.o > diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c > new file mode 100644 > index 0000000..e0bde79 > --- /dev/null > +++ b/drivers/bluetooth/btwilink.c > @@ -0,0 +1,455 @@ > +/* > + * =C2=A0Texas Instrument's Bluetooth Driver For Shared Transport. > + * > + * =C2=A0Bluetooth Driver acts as interface between HCI CORE and > + * =C2=A0TI Shared Transport Layer. > + * > + * =C2=A0Copyright (C) 2009-2010 Texas Instruments > + * =C2=A0Author: Raja Mani > + * =C2=A0 =C2=A0 Pavan Savoy > + * > + * =C2=A0This program is free software; you can redistribute it and/or m= odify > + * =C2=A0it under the terms of the GNU General Public License version 2 = as > + * =C2=A0published by the Free Software Foundation. > + * > + * =C2=A0This program is distributed in the hope that it will be useful, > + * =C2=A0but WITHOUT ANY WARRANTY; without even the implied warranty of > + * =C2=A0MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. =C2=A0See = the > + * =C2=A0GNU General Public License for more details. > + * > + * =C2=A0You should have received a copy of the GNU General Public Licen= se > + * =C2=A0along with this program; if not, write to the Free Software > + * =C2=A0Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA =C2=A0= 02111-1307 =C2=A0USA > + * > + */ > + > +#include > +#include > +#include > + > +#include > + > +/* Bluetooth Driver Version */ > +#define VERSION =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "1.0" > + > +/* Defines number of seconds to wait for reg completion > + * callback getting called from ST (in case,registration > + * with ST returns PENDING status) > + */ > +#define BT_REGISTER_TIMEOUT =C2=A0 6000 =C2=A0 =C2=A0 /* 6 sec */ > + > +/** > + * struct ti_st - BT driver operation structure > + * @hdev: hci device pointer which binds to bt driver > + * @flags: used locally,to maintain various BT driver status > + * @streg_cbdata: to hold ST registration callback status > + * @st_write: write function pointer of ST driver > + * @wait_for_btdrv_reg_completion - completion sync between ti_st_open > + * =C2=A0 =C2=A0 and ti_st_registration_completion_cb. > + */ > +struct ti_st { > + =C2=A0 =C2=A0 =C2=A0 struct hci_dev *hdev; > + =C2=A0 =C2=A0 =C2=A0 char streg_cbdata; > + =C2=A0 =C2=A0 =C2=A0 long (*st_write) (struct sk_buff *); > + =C2=A0 =C2=A0 =C2=A0 struct completion wait_for_btdrv_reg_completion; > +}; > + > +static int reset; > + > +/* Increments HCI counters based on pocket ID (cmd,acl,sco) */ > +static inline void ti_st_tx_complete(struct ti_st *hst, int pkt_type) > +{ > + =C2=A0 =C2=A0 =C2=A0 struct hci_dev *hdev; > + =C2=A0 =C2=A0 =C2=A0 hdev =3D hst->hdev; > + > + =C2=A0 =C2=A0 =C2=A0 /* Update HCI stat counters */ > + =C2=A0 =C2=A0 =C2=A0 switch (pkt_type) { > + =C2=A0 =C2=A0 =C2=A0 case HCI_COMMAND_PKT: > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hdev->stat.cmd_tx++; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; > + > + =C2=A0 =C2=A0 =C2=A0 case HCI_ACLDATA_PKT: > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hdev->stat.acl_tx++; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; > + > + =C2=A0 =C2=A0 =C2=A0 case HCI_SCODATA_PKT: > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hdev->stat.sco_tx++; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; > + =C2=A0 =C2=A0 =C2=A0 } > +} > + > +/* ------- Interfaces to Shared Transport ------ */ > + > +/* Called by ST layer to indicate protocol registration completion > + * status.ti_st_open() function will wait for signal from this > + * API when st_register() function returns ST_PENDING. > + */ > +static void st_registration_completion_cb(void *priv_data, char data) > +{ > + =C2=A0 =C2=A0 =C2=A0 struct ti_st *lhst =3D (struct ti_st *)priv_data; > + =C2=A0 =C2=A0 =C2=A0 /* ti_st_open() function needs value of 'data' to = know > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* the registration status(success/fail),So h= ave a back > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* up of it. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 lhst->streg_cbdata =3D data; > + > + =C2=A0 =C2=A0 =C2=A0 /* Got a feedback from ST for BT driver registrati= on > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* request.Wackup ti_st_open() function to co= ntinue > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* it's open operation. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 complete(&lhst->wait_for_btdrv_reg_completion); > +} > + > +/* Called by Shared Transport layer when receive data is > + * available */ > +static long st_receive(void *priv_data, struct sk_buff *skb) > +{ > + =C2=A0 =C2=A0 =C2=A0 int err; > + =C2=A0 =C2=A0 =C2=A0 struct ti_st *lhst =3D (struct ti_st *)priv_data; > + > + =C2=A0 =C2=A0 =C2=A0 if (skb =3D=3D NULL) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Invalid SKB re= ceived from ST"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EFAULT; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 if (!lhst) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree_skb(skb); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Invalid ti_st = memory,freeing SKB"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EFAULT; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 skb->dev =3D (struct net_device *)lhst->hdev; > + =C2=A0 =C2=A0 =C2=A0 /* Forward skb to HCI CORE layer */ > + =C2=A0 =C2=A0 =C2=A0 err =3D hci_recv_frame(skb); > + =C2=A0 =C2=A0 =C2=A0 if (err) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree_skb(skb); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Unable to push= skb to HCI CORE(%d),freeing SKB", > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 err); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return err; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 lhst->hdev->stat.byte_rx +=3D skb->len; > + =C2=A0 =C2=A0 =C2=A0 return 0; > +} > + > +/* ------- Interfaces to HCI layer ------ */ > + > +/* Called from HCI core to initialize the device */ > +static int ti_st_open(struct hci_dev *hdev) > +{ > + =C2=A0 =C2=A0 =C2=A0 static struct st_proto_s ti_st_proto; > + =C2=A0 =C2=A0 =C2=A0 unsigned long timeleft; > + =C2=A0 =C2=A0 =C2=A0 struct ti_st *hst; > + =C2=A0 =C2=A0 =C2=A0 int err; > + =C2=A0 =C2=A0 =C2=A0 err =3D 0; > + > + =C2=A0 =C2=A0 =C2=A0 BT_DBG("%s %p", hdev->name, hdev); > + =C2=A0 =C2=A0 =C2=A0 hst =3D hdev->driver_data; > + > + =C2=A0 =C2=A0 =C2=A0 /* Populate BT driver info required by ST */ > + =C2=A0 =C2=A0 =C2=A0 memset(&ti_st_proto, 0, sizeof(ti_st_proto)); > + > + =C2=A0 =C2=A0 =C2=A0 /* BT driver ID */ > + =C2=A0 =C2=A0 =C2=A0 ti_st_proto.type =3D ST_BT; > + > + =C2=A0 =C2=A0 =C2=A0 /* Receive function which called from ST */ > + =C2=A0 =C2=A0 =C2=A0 ti_st_proto.recv =3D st_receive; > + > + =C2=A0 =C2=A0 =C2=A0 /* Callback to be called when registration is pend= ing */ > + =C2=A0 =C2=A0 =C2=A0 ti_st_proto.reg_complete_cb =3D st_registration_co= mpletion_cb; > + > + =C2=A0 =C2=A0 =C2=A0 /* send in the hst to be received at registration = complete callback > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* and during st's receive > + =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 ti_st_proto.priv_data =3D hst; > + > + =C2=A0 =C2=A0 =C2=A0 /* Register with ST layer */ > + =C2=A0 =C2=A0 =C2=A0 err =3D st_register(&ti_st_proto); > + =C2=A0 =C2=A0 =C2=A0 if (err =3D=3D -EINPROGRESS) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Prepare wait-for-co= mpletion handler data structures. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* Needed to sync= ronize this and st_registration_completion_cb() > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* functions. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 init_completion(&hst->= wait_for_btdrv_reg_completion); > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Reset ST registrati= on callback status flag , this value > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* will be update= d in ti_st_registration_completion_cb() > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* function whene= ver it called from ST driver. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hst->streg_cbdata =3D = -EINPROGRESS; > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* ST is busy with oth= er protocol registration(may be busy with > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* firmware downl= oad).So,Wait till the registration callback > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* (passed as a a= rgument to st_register() function) getting > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* called from ST= . > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_DBG(" %s waiting fo= r reg completion signal from ST", > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __func__); > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 timeleft =3D > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 wait_for_completion_timeout > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (&hst->wait_for_btdrv_reg_completion, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0msecs_to_jiffies(BT_REGISTER_TIMEOUT)); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!timeleft) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 BT_ERR("Timeout(%d sec),didn't get reg" > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "completion = signal from ST", > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_REGISTER_= TIMEOUT / 1000); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 return -ETIMEDOUT; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Is ST registration = callback called with ERROR value? */ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (hst->streg_cbdata = !=3D 0) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 BT_ERR("ST reg completion CB called with invalid" > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "status %d",= hst->streg_cbdata); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 return -EAGAIN; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 err =3D 0; > + =C2=A0 =C2=A0 =C2=A0 } else if (err =3D=3D -1) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("st_register fa= iled %d", err); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EAGAIN; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 /* Do we have proper ST write function? */ > + =C2=A0 =C2=A0 =C2=A0 if (ti_st_proto.write !=3D NULL) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* We need this pointe= r for sending any Bluetooth pkts */ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hst->st_write =3D ti_s= t_proto.write; > + =C2=A0 =C2=A0 =C2=A0 } else { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("failed to get = ST write func pointer"); > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Undo registration w= ith ST */ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 err =3D st_unregister(= ST_BT); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (err < 0) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 BT_ERR("st_unregister failed %d", err); > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hst->st_write =3D NULL= ; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EAGAIN; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 /* Registration with ST layer is completed success= fully, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* now chip is ready to accept commands from = HCI CORE. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* Mark HCI Device flag as RUNNING > + =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 set_bit(HCI_RUNNING, &hdev->flags); > + =C2=A0 =C2=A0 =C2=A0 return err; > +} > + > +/* Close device */ > +static int ti_st_close(struct hci_dev *hdev) > +{ > + =C2=A0 =C2=A0 =C2=A0 int err =3D 0; > + =C2=A0 =C2=A0 =C2=A0 struct ti_st *hst; > + > + =C2=A0 =C2=A0 =C2=A0 hst =3D hdev->driver_data; > + > + =C2=A0 =C2=A0 =C2=A0 /* Clear HCI device RUNNING flag */ > + =C2=A0 =C2=A0 =C2=A0 if (!test_and_clear_bit(HCI_RUNNING, &hdev->flags)= ) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("HCI not RUNNIN= G?"); > + > + =C2=A0 =C2=A0 =C2=A0 /* continue to unregister from transport */ > + =C2=A0 =C2=A0 =C2=A0 err =3D st_unregister(ST_BT); > + =C2=A0 =C2=A0 =C2=A0 if (err !=3D 0) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hst->st_write =3D NULL= ; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("st_unregister = failed %d", err); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EBUSY; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 hst->st_write =3D NULL; > + =C2=A0 =C2=A0 =C2=A0 return err; > +} > + > +/* Called from HCI CORE , Sends frames to Shared Transport */ > +static int ti_st_send_frame(struct sk_buff *skb) > +{ > + =C2=A0 =C2=A0 =C2=A0 struct hci_dev *hdev; > + =C2=A0 =C2=A0 =C2=A0 struct ti_st *hst; > + =C2=A0 =C2=A0 =C2=A0 long len; > + > + =C2=A0 =C2=A0 =C2=A0 if (skb =3D=3D NULL) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Invalid skb re= ceived from HCI CORE"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENOMEM; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 hdev =3D (struct hci_dev *)skb->dev; > + =C2=A0 =C2=A0 =C2=A0 if (!hdev) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("SKB received f= or invalid HCI Device (hdev=3DNULL)"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENODEV; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 if (!test_bit(HCI_RUNNING, &hdev->flags)) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Device is not = running"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EBUSY; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 hst =3D (struct ti_st *)hdev->driver_data; > + > + =C2=A0 =C2=A0 =C2=A0 /* Prepend skb with frame type */ > + =C2=A0 =C2=A0 =C2=A0 memcpy(skb_push(skb, 1), &bt_cb(skb)->pkt_type, 1)= ; > + > + =C2=A0 =C2=A0 =C2=A0 BT_DBG(" %s: type %d len %d", hdev->name, bt_cb(sk= b)->pkt_type, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 skb->len); > + > + =C2=A0 =C2=A0 =C2=A0 /* Insert skb to shared transport layer's transmit= queue. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* Freeing skb memory is taken care in shared= transport layer, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0* so don't free skb memory here. > + =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 if (!hst->st_write) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree_skb(skb); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR(" Can't write t= o ST, st_write null?"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EAGAIN; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 len =3D hst->st_write(skb); > + =C2=A0 =C2=A0 =C2=A0 if (len < 0) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree_skb(skb); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR(" ST write fail= ed (%ld)", len); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EAGAIN; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 /* ST accepted our skb. So, Go ahead and do rest *= / > + =C2=A0 =C2=A0 =C2=A0 hdev->stat.byte_tx +=3D len; > + =C2=A0 =C2=A0 =C2=A0 ti_st_tx_complete(hst, bt_cb(skb)->pkt_type); > + > + =C2=A0 =C2=A0 =C2=A0 return 0; > +} > + > +static void ti_st_destruct(struct hci_dev *hdev) > +{ > + =C2=A0 =C2=A0 =C2=A0 if (!hdev) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Destruct calle= d with invalid HCI Device" > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "(hdev=3DNULL)"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 BT_DBG("%s", hdev->name); > + > + =C2=A0 =C2=A0 =C2=A0 /* free ti_st memory */ > + =C2=A0 =C2=A0 =C2=A0 if (hdev->driver_data !=3D NULL) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree(hdev->driver_dat= a); > + > + =C2=A0 =C2=A0 =C2=A0 return; > +} > + > +/* Creates new HCI device */ > +static int ti_st_register_dev(struct ti_st *hst) > +{ > + =C2=A0 =C2=A0 =C2=A0 struct hci_dev *hdev; > + > + =C2=A0 =C2=A0 =C2=A0 /* Initialize and register HCI device */ > + =C2=A0 =C2=A0 =C2=A0 hdev =3D hci_alloc_dev(); > + =C2=A0 =C2=A0 =C2=A0 if (!hdev) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Can't allocate= HCI device"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENOMEM; > + =C2=A0 =C2=A0 =C2=A0 } > + =C2=A0 =C2=A0 =C2=A0 BT_DBG(" HCI device allocated. hdev=3D %p", hdev); > + > + =C2=A0 =C2=A0 =C2=A0 hst->hdev =3D hdev; > + =C2=A0 =C2=A0 =C2=A0 hdev->bus =3D HCI_UART; > + =C2=A0 =C2=A0 =C2=A0 hdev->driver_data =3D hst; > + =C2=A0 =C2=A0 =C2=A0 hdev->open =3D ti_st_open; > + =C2=A0 =C2=A0 =C2=A0 hdev->close =3D ti_st_close; > + =C2=A0 =C2=A0 =C2=A0 hdev->flush =3D NULL; > + =C2=A0 =C2=A0 =C2=A0 hdev->send =3D ti_st_send_frame; > + =C2=A0 =C2=A0 =C2=A0 hdev->destruct =3D ti_st_destruct; > + =C2=A0 =C2=A0 =C2=A0 hdev->owner =3D THIS_MODULE; > + > + =C2=A0 =C2=A0 =C2=A0 if (reset) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 set_bit(HCI_QUIRK_NO_R= ESET, &hdev->quirks); > + > + =C2=A0 =C2=A0 =C2=A0 if (hci_register_dev(hdev) < 0) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Can't register= HCI device"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hci_free_dev(hdev); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENODEV; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 BT_DBG(" HCI device registered. hdev=3D %p", hdev)= ; > + =C2=A0 =C2=A0 =C2=A0 return 0; > +} > + > + > +static int bt_ti_probe(struct platform_device *pdev) > +{ > + =C2=A0 =C2=A0 =C2=A0 int err; > + =C2=A0 =C2=A0 =C2=A0 static struct ti_st *hst; > + =C2=A0 =C2=A0 =C2=A0 err =3D 0; > + > + =C2=A0 =C2=A0 =C2=A0 BT_DBG(" Bluetooth Driver Version %s", VERSION); > + > + =C2=A0 =C2=A0 =C2=A0 /* Allocate local resource memory */ > + =C2=A0 =C2=A0 =C2=A0 hst =3D kzalloc(sizeof(struct ti_st), GFP_KERNEL); > + =C2=A0 =C2=A0 =C2=A0 if (!hst) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Can't allocate= control structure"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENFILE; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 /* Expose "hciX" device to user space */ > + =C2=A0 =C2=A0 =C2=A0 err =3D ti_st_register_dev(hst); > + =C2=A0 =C2=A0 =C2=A0 if (err) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Release local resou= rce memory */ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree(hst); > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("Unable to expo= se hci0 device(%d)", err); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return err; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 dev_set_drvdata(&pdev->dev, hst); > + =C2=A0 =C2=A0 =C2=A0 return err; > +} > + > +static int bt_ti_remove(struct platform_device *pdev) > +{ > + =C2=A0 =C2=A0 =C2=A0 struct ti_st *hst; > + > + =C2=A0 =C2=A0 =C2=A0 hst =3D dev_get_drvdata(&pdev->dev); > + =C2=A0 =C2=A0 =C2=A0 /* Deallocate local resource's memory =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0 if (hst) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 struct hci_dev *hdev = =3D hst->hdev; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (hdev =3D=3D NULL) = { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 BT_ERR("Invalid hdev memory"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 kfree(hst); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ti_st_close(hdev); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 hci_unregister_dev(hdev); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 /* Free HCI device memory */ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 hci_free_dev(hdev); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > + =C2=A0 =C2=A0 =C2=A0 } > + =C2=A0 =C2=A0 =C2=A0 return 0; > +} > + > +static struct platform_driver bt_ti_driver =3D { > + =C2=A0 =C2=A0 =C2=A0 .probe =3D bt_ti_probe, > + =C2=A0 =C2=A0 =C2=A0 .remove =3D bt_ti_remove, > + =C2=A0 =C2=A0 =C2=A0 .driver =3D { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .name =3D "ti_st_bluet= ooth", > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .owner =3D THIS_MODULE= , > + =C2=A0 =C2=A0 =C2=A0 }, > +}; > + > +/* ------- Module Init/Exit interfaces ------ */ > +static int __init bt_drv_init(void) > +{ > + =C2=A0 =C2=A0 =C2=A0 long ret =3D 0; > + =C2=A0 =C2=A0 =C2=A0 ret =3D platform_driver_register(&bt_ti_driver); > + =C2=A0 =C2=A0 =C2=A0 if (ret !=3D 0) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BT_ERR("bt_ti platform= drv registration failed"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -1; > + =C2=A0 =C2=A0 =C2=A0 } > + =C2=A0 =C2=A0 =C2=A0 return 0; > +} > + > +static void __exit bt_drv_exit(void) > +{ > + =C2=A0 =C2=A0 =C2=A0 platform_driver_unregister(&bt_ti_driver); > +} > + > +module_init(bt_drv_init); > +module_exit(bt_drv_exit); > + > +/* ------ Module Info ------ */ > + > +module_param(reset, bool, 0644); > +MODULE_PARM_DESC(reset, "Send HCI reset command on initialization"); > +MODULE_AUTHOR("Raja Mani "); > +MODULE_DESCRIPTION("Bluetooth Driver for TI Shared Transport" VERSION); > +MODULE_VERSION(VERSION); > +MODULE_LICENSE("GPL"); > -- > 1.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth= " in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =C2=A0http://vger.kernel.org/majordomo-info.html >