Return-Path: Date: Thu, 7 Oct 2010 21:59:43 +0100 From: Alan Cox To: "Savoy, Pavan" Cc: Jiri Slaby , "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging Message-ID: <20101007215943.45365f45@lxorguk.ukuu.org.uk> In-Reply-To: <19F8576C6E063C45BE387C64729E739404AA21D248@dbde02.ent.ti.com> References: <1286381895-11329-1-git-send-email-pavan_savoy@ti.com> <1286381895-11329-2-git-send-email-pavan_savoy@ti.com> <4CACD234.7020900@gmail.com> <19F8576C6E063C45BE387C64729E739404AA21CEA1@dbde02.ent.ti.com> <4CACF5A7.3010601@gmail.com> <19F8576C6E063C45BE387C64729E739404AA21CEC6@dbde02.ent.ti.com> <4CAD7DAB.8030209@gmail.com> <19F8576C6E063C45BE387C64729E739404AA21D193@dbde02.ent.ti.com> <4CAE10C0.9000106@gmail.com> <19F8576C6E063C45BE387C64729E739404AA21D220@dbde02.ent.ti.com> <20101007203801.1c55a1d3@lxorguk.ukuu.org.uk> <19F8576C6E063C45BE387C64729E739404AA21D23B@dbde02.ent.ti.com> <20101007213503.657bcab0@lxorguk.ukuu.org.uk> <19F8576C6E063C45BE387C64729E739404AA21D248@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-bluetooth-owner@vger.kernel.org List-ID: > But, I want to attach my data not when ldsic is opened, but when ldisc is registered. > I want to begin accessing the data when ldisc is opened. How can you attach per tty data when the ldisc is registered - the relevant tty driver might not even have been loaded at that point. The user may not even have been to the shop and bought it even ! What sort of data is this ? > to be like a bunch of helpers (1 for FM, 1 for GPS, 1 for NFC, 1 for power-management), also the problem of who owns the /dev/tty begins to occur, Bluetooth has a utility called hciattach, I don't want my FM radio software to run hciattach when /dev/radio0 is opened and communicated via FM. I would have assumed the hotplug script would have run your own attach and daemon and the FM radio etc would talk to the ldisc via other kernel interfaces it presented. So whenever the hardware is detected it would load the hardware driver The hardware driver would create a tty instance for each physical port The hotplug user space would run 'ti-st-attach' as a helper which would load the ldisc and set up the bluetooth as well as providing exported methods for FM radio etc. > In any case, the ti-st/ seems better now by look of things, I certainly welcome suggestions to improve it. > Also, is there any plan to re-write whole of TTY like a the i2C or the SPI bus structure? > > Here I can imagine, all TTY line disciplines being sort of protocol/client drivers, the TTY sub-system in itself would be like the algos driver and then > The uart drivers (like 8250.c) can be the adapter drivers.. What say? They already are, with the one oddity being that something needs to have it opened from user space and to attach the ldisc. Thats fixable but hard to fix and I'm not aware of any plan to do so - mostly because nobody needs it so far. Alan