Return-Path: Subject: Re: [PATCH 1/2] drivers:bluetooth: TI_ST bluetooth driver From: Marcel Holtmann To: Greg KH Cc: pavan-savoy@ti.com, linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com, linux-kernel@vger.kernel.org, Pavan Savoy In-Reply-To: <20101007143409.GB14913@kroah.com> References: <1286404493-23816-1-git-send-email-pavan-savoy@ti.com> <1286404493-23816-2-git-send-email-pavan-savoy@ti.com> <1286445948.6145.70.camel@aeonflux> <20101007143409.GB14913@kroah.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Oct 2010 17:21:07 +0200 Message-ID: <1286464867.6145.148.camel@aeonflux> Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Greg, > > > This is the bluetooth protocol driver for the TI WiLink7 chipsets. > > > Texas Instrument's WiLink chipsets combine wireless technologies > > > like BT, FM, GPS and WLAN onto a single chip. > > > > > > This Bluetooth driver works on top of the TI_ST shared transport > > > line discipline driver which also allows other drivers like > > > FM V4L2 and GPS character driver to make use of the same UART interface. > > > > > > Signed-off-by: Pavan Savoy > > > --- > > > drivers/bluetooth/bt_ti.c | 463 ++++++++++++++++++++++++++++++++++++ > > > drivers/staging/ti-st/bt_drv.c | 509 ---------------------------------------- > > > drivers/staging/ti-st/bt_drv.h | 61 ----- > > > 3 files changed, 463 insertions(+), 570 deletions(-) > > > create mode 100644 drivers/bluetooth/bt_ti.c > > > delete mode 100644 drivers/staging/ti-st/bt_drv.c > > > delete mode 100644 drivers/staging/ti-st/bt_drv.h > > > > I don't care about staging at all. So you sort that out with Greg. > > > > Submit your driver for upstream inclusion. And once accepted you can pin > > Greg about removing it. > > The driver is already in staging, this is the request to move it out of > staging and into the "correct" place in the tree. The core of the ti-st > code is now in the drivers/misc/ directory in the linux-next tree, and > this patch is the request to move the bluetooth drive into the proper > drivers/bluetooth/ location. nice idea, but I don't want it that way. I am not dealing with staging at all. They can submit this driver for upstream inclusion and then delete it in a second step from staging. Or the other way around. And as long as this driver registers a Bluetooth HCI device in its module_init routine it is not ready for upstream. This needs to be fixed first and I mentioned that already before. Regards Marcel