Return-Path: MIME-Version: 1.0 In-Reply-To: <20101122144301.GC2303@jh-x301> References: <1290413446-5391-1-git-send-email-sancane@gmail.com> <1290413266-3949-1-git-send-email-santoscadenas@gmail.com> <20101122144301.GC2303@jh-x301> From: Jose Antonio Santos Cadenas Date: Mon, 22 Nov 2010 15:54:03 +0100 Message-ID: Subject: Re: [PATCH 2/2] Increment reference counter when a io_watcher is added To: Jose Antonio Santos Cadenas , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, 2010/11/22 Johan Hedberg : > Hi Jose, > > On Mon, Nov 22, 2010, Jose Antonio Santos Cadenas wrote: >> Also a destroy function is added in order to avoid memory leaks >> --- >> ?health/mcap.c | ? 28 +++++++++++++++++++--------- >> ?1 files changed, 19 insertions(+), 9 deletions(-) > > The patch content itself is fine but you need to fix the commit message. > Now you have half of the info in the summary and half in the message > body (both halves being equaly relevant). The summary line should be a > summary of the whole patch (in this case it could be e.g. "Fix MDL > reference counting for IO watchers") and the body should contain the > details. So please reformulate, resend, and pay more attention to this > kind of things in the future. Thanks :) Sorry for for the inconvenience, I'm fixing this and sending the new patch. I'll try be more carefully with the commit messages in the future. Regards > > Johan >