Return-Path: MIME-Version: 1.0 In-Reply-To: <20101121131442.GA22320@jh-x301> References: <1290343578-986-1-git-send-email-santoscadenas@gmail.com> <20101121131442.GA22320@jh-x301> From: Jose Antonio Santos Cadenas Date: Sun, 21 Nov 2010 17:07:42 +0100 Message-ID: Subject: Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method To: Jose Antonio Santos Cadenas , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, 2010/11/21 Johan Hedberg : > Hi Jose, > > On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote: >> In the current method implementation the parameter is not used. >> --- >> ?doc/agent-api.txt | ? ?5 +---- >> ?1 files changed, 1 insertions(+), 4 deletions(-) > > Do you actually have a BT 2.1 keyboard to test this with? I'm lost, why do I need a BT keyboard? > The right fix > is to fix the code and not the spec since we do want the UI to get the > hints about entered characters. I also think that an other way to correct this is to change the code to follow the specification, but as I see that the specification didn't have changes since 2008 I thought that was an obsolete documentation, because in the source code there is no reference to the entered parameter. Have you got any suggestions about the better way to add this parameter in order to follow the API in the documentation? Nevertheless I'll have a deeper look to the code looking for hints. > > Johan > Regards. Jose.