Return-Path: Date: Mon, 1 Nov 2010 10:51:49 +0200 From: Ville Tervo To: "ext Gustavo F. Padovan" Cc: Vinicius Gomes , ext Anderson Briglia , "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH 2/6] Bluetooth: fix receiving L2CAP packets over LE Message-ID: <20101101085149.GA10917@null> References: <1287791820-22693-3-git-send-email-anderson.briglia@openbossa.org> <20101029104435.GQ15050@null> <20101029205033.GB14961@vigoh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20101029205033.GB14961@vigoh> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Fri, Oct 29, 2010 at 10:50:33PM +0200, ext Gustavo F. Padovan wrote: > Hi, > > * Vinicius Gomes [2010-10-29 09:41:55 -0400]: > > > Hi Ville, > > > > On Fri, Oct 29, 2010 at 6:44 AM, Ville Tervo wrote: > > > Hi Anderson, > > > > > > On Sat, Oct 23, 2010 at 01:56:56AM +0200, ext Anderson Briglia wrote: > > >> From: Vinicius Costa Gomes > > >> > > >> As L2CAP packets coming over LE don't have any more encapsulation, > > >> other than L2CAP, we are able to process them as soon as they arrive. > > > > > > Why is this change needed? Was something broken without this patch? > > > > > > > This change is needed because without it the receiving side would > > always think that it was receiving continuation frames. > > > > As the flags parameter is zero, it would fall into the "} else {" > > condition, and because no frame was received before, conn->rx_len > > would be zero and the frame would be discarded. Without this patch I > > was seeing those "Unexpected continuation frame ..." messages on the > > receiving side. > > From what I understood the flags are only for ACL connections and LE > links doesn't have fragmentation, right? So we don't need to check flags > here, actually it seems we don't have flags for LE like ACL. Yes it has. See spec. Vol 2 Part E 5.4.2. It seems that controller should not be sending 0 PB flag in any situation (except loopback). Vinicius that controller are you using? I haven't seen this ever in my testing. -- Ville